Re: [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses

[Eli Zaretskii <eliz@gnu.org>]

> Date: Wed, 10 Feb 2016 22:08:17 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > That's very strange.  If I remove connect-to-tls-ipv6-nowait from the
> > file and say "make lisp/net/network-stream-tests" then all the remaining
> > tests pass.
> 
> Here, echo-server-nowait fails if I do that.
> 
> > And echo-server-nowait doesn't talk to the same port at the TLS tests,
> > so that's doubly weird.
> 
> Yep.  Any ideas besides some weird timing problem?
> 
> > > However, when connect-to-tls-ipv6-nowait is left to run (and fail),
> > > then echo-server-nowait succeeds.
> > 
> > When it fails, is the gnutls-serv process still running?
> 
> By "it" do you mean connect-to-tls-ipv6-nowait?  If so, AFAICT
> gnutls-serv exits immediately when the failure is reported.

It's indeed some weird problem with timing or maybe with events in
batch mode.  The patch below (which also skips the IPv6 test on
MS-Windows) fixes it.  Do you see any problems with it?

diff --git a/test/lisp/net/network-stream-tests.el b/test/lisp/net/network-stream-tests.el
index 92c5370..d3f229e 100644
--- a/test/lisp/net/network-stream-tests.el
+++ b/test/lisp/net/network-stream-tests.el
@@ -192,6 +192,7 @@ make-tls-server
     (setq status (gnutls-peer-status proc))
     (should (consp status))
     (delete-process proc)
+    (sleep-for 0.1)
     (let ((issuer (plist-get (plist-get status :certificate) :issuer)))
       (should (stringp issuer))
       (setq issuer (split-string issuer ","))
@@ -200,6 +201,7 @@ make-tls-server
 (ert-deftest connect-to-tls-ipv6-nowait ()
   (skip-unless (executable-find "gnutls-serv"))
   (skip-unless (gnutls-available-p))
+  (skip-unless (not (eq system-type 'windows-nt)))
   (let ((server (make-tls-server))
         (times 0)
         proc status)
@@ -226,6 +228,7 @@ make-tls-server
     (setq status (gnutls-peer-status proc))
     (should (consp status))
     (delete-process proc)
+    (sleep-for 0.1)
     (let ((issuer (plist-get (plist-get status :certificate) :issuer)))
       (should (stringp issuer))
       (setq issuer (split-string issuer ","))