From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Building Emacs on MSYS2 Date: Sat, 16 Apr 2016 09:42:16 +0300 Message-ID: <83bn5acawn.fsf@gnu.org> References: <56CCD91E.6070507@alice.it> <570EC198.5090407@alice.it> <570EF300.3050104@cs.ucla.edu> <570F4EC7.3060403@alice.it> <83twj4dx7q.fsf@gnu.org> <878u0gyyge.fsf_-_@wanadoo.es> <570FC0BC.8030709@cs.ucla.edu> <874mb4yxqi.fsf@wanadoo.es> <83potsduv5.fsf@gnu.org> <87vb3kxho5.fsf@wanadoo.es> <83mvowdru7.fsf@gnu.org> <87r3e8x88h.fsf@wanadoo.es> <571102B8.8010004@cs.ucla.edu> <87inziyjb5.fsf@wanadoo.es> <57112544.5050508@cs.ucla.edu> <87d1pqycsz.fsf@wanadoo.es> <57113DC4.4010303@cs.ucla.edu> <878u0ey81k.fsf@wanadoo.es> <83lh4ed4ht.fsf@gnu.org> <87zisuwrng.fsf@wanadoo.es> <868u0ea6zm.fsf@stephe-leake.org> <87vb3iwmi5.fsf@wanadoo.es> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1460788964 29764 80.91.229.3 (16 Apr 2016 06:42:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Apr 2016 06:42:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?=C3=93scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 16 08:42:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arJwJ-0008As-JZ for ged-emacs-devel@m.gmane.org; Sat, 16 Apr 2016 08:42:43 +0200 Original-Received: from localhost ([::1]:49830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arJwI-0003Qs-Ux for ged-emacs-devel@m.gmane.org; Sat, 16 Apr 2016 02:42:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arJwF-0003Np-A9 for emacs-devel@gnu.org; Sat, 16 Apr 2016 02:42:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arJwC-0006jD-4I for emacs-devel@gnu.org; Sat, 16 Apr 2016 02:42:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arJwC-0006j9-1N; Sat, 16 Apr 2016 02:42:36 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2761 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1arJwB-0008SY-CX; Sat, 16 Apr 2016 02:42:35 -0400 In-reply-to: <87vb3iwmi5.fsf@wanadoo.es> (message from =?utf-8?Q?=C3=93sca?= =?utf-8?Q?r?= Fuentes on Sat, 16 Apr 2016 00:11:30 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202979 Archived-At: > From: Óscar Fuentes > Date: Sat, 16 Apr 2016 00:11:30 +0200 > > You can also try to see what happens if you omit the patches. Remove > image.c.diff from `source' and the corresponding SHA hash from > `sha256sums' (the hashes of the files are listed in the same order as in > `sources'). See if the build breaks. See if imagemagick is detected. See > if you can use imagemagick from the resulting package. Report your > results. The Imagemagick build is not officially supported in the MS-Windows build, because no one submitted patches to make it behave like all the other optional image libraries. By that I mean: be able to run an Emacs binary built with Imagemagick support on a system that doesn't have the Imagemagick DLLs installed. AFAIU, the image.c.diff hack allows one to build Emacs with Imagemagick, but the resulting binary will refuse to run on a system where it cannot load the Imagemagick DLLs at startup. That is not how we handle optional libraries in the Windows build. So the right way of handling this problem is to modify the Emacs Imagemagick support code in image.c so that it uses LOAD_DLL_FN etc. (There's one complication with Imagemagick: it needs to load 2 DLLs rather than one, and figuring out how to deal with that is part of the job.)