From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Sun, 16 Apr 2017 19:54:04 +0300 Message-ID: <83bmrwfg43.fsf@gnu.org> References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> <83r30vh2k3.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492361630 25893 195.159.176.226 (16 Apr 2017 16:53:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Apr 2017 16:53:50 +0000 (UTC) Cc: juri@jurta.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 16 18:53:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cznQf-0006S5-SZ for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 18:53:37 +0200 Original-Received: from localhost ([::1]:32990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cznQl-0004n1-Sl for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 12:53:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cznQf-0004mj-Np for emacs-devel@gnu.org; Sun, 16 Apr 2017 12:53:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cznQc-0002KA-N8 for emacs-devel@gnu.org; Sun, 16 Apr 2017 12:53:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cznQc-0002K6-JR; Sun, 16 Apr 2017 12:53:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4123 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cznQb-0007Je-Oi; Sun, 16 Apr 2017 12:53:34 -0400 In-reply-to: (message from Stefan Monnier on Sun, 16 Apr 2017 09:42:04 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214013 Archived-At: > From: Stefan Monnier > Cc: Juri Linkov , emacs-devel@gnu.org > Date: Sun, 16 Apr 2017 09:42:04 -0400 > > > After so many years that this code existed, I see no reason to rock > > the boat now. This bike shed's color was fixed long ago; if we didn't > > care during all these years, we should definitely leave it at that > > now. > > I think the patch below would make the function more robust and > eliminate the need to warn about weird behaviors in unusual circumstances. Thanks, but I'm not interested. This code existed for years, and it never bothered you or anyone else, so we won't change it now.