* Emacs master broken
@ 2017-09-13 21:54 Angelo Graziosi
2017-09-14 0:59 ` Paul Eggert
2017-09-14 2:41 ` Eli Zaretskii
0 siblings, 2 replies; 8+ messages in thread
From: Angelo Graziosi @ 2017-09-13 21:54 UTC (permalink / raw)
To: emacs-devel
A recent commit should have broken the build of master.
I would say this:
Mark Oteiza commit: 5d4c539bd7e15e7fd0fb092276791b6287260a9a
Add lcms2 interface
configure.ac: Add boilerplate for configuring and detecting liblcms2.
etc/NEWS: Mention new configure option and color-distance change.
src/Makefile.in: Add references to lcms.c and liblcms.
src/emacs.c: Define lcms2 symbols.
src/lcms.c: New file.
src/lisp.h: Add declaration for lcms2.
src/xfaces.c: Add optional METRIC argument.
or this:
Mark Oteiza commit: 3d96fc15362453f43f3f04ffa288a57ee1e633c3
Provide an lcms2 feature
* src/lcms.c (syms_of_lcms2): Provide "lcms2".
Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
Angelo
[...]
GEN ../../lisp/international/cp51932.el
GEN ../../lisp/international/eucjp-ms.el
GEN charsets.stamp
make[2]: uscita dalla directory "/tmp/emacs-master/admin/charsets"
make -C ../admin/unidata charscript.el
make[2]: ingresso nella directory "/tmp/emacs-master/admin/unidata"
GEN ../../lisp/international/charscript.el
make[2]: uscita dalla directory "/tmp/emacs-master/admin/unidata"
CCLD temacs.exe
lcms.o:lcms.c:(.text+0x196): undefined reference to `cmsCIE2000DeltaE'
lcms.o:lcms.c:(.text+0x196): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIE2000DeltaE'
lcms.o:lcms.c:(.text+0x591): undefined reference to `cmsCIECAM02Init'
lcms.o:lcms.c:(.text+0x591): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIECAM02Init'
lcms.o:lcms.c:(.text+0x59e): undefined reference to `cmsCIECAM02Init'
lcms.o:lcms.c:(.text+0x59e): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIECAM02Init'
lcms.o:lcms.c:(.text+0x5b1): undefined reference to `cmsCIECAM02Forward'
lcms.o:lcms.c:(.text+0x5b1): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIECAM02Forward'
lcms.o:lcms.c:(.text+0x5c1): undefined reference to `cmsCIECAM02Forward'
lcms.o:lcms.c:(.text+0x5c1): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIECAM02Forward'
lcms.o:lcms.c:(.text+0x5c9): undefined reference to `cmsCIECAM02Done'
lcms.o:lcms.c:(.text+0x5c9): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIECAM02Done'
lcms.o:lcms.c:(.text+0x5d1): undefined reference to `cmsCIECAM02Done'
lcms.o:lcms.c:(.text+0x5d1): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIECAM02Done'
collect2.exe: error: ld returned 1 exit status
make[1]: *** [Makefile:600: temacs.exe] Error 1
make[1]: uscita dalla directory "/tmp/emacs-master/src"
make: *** [Makefile:416: src] Error 2
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-13 21:54 Emacs master broken Angelo Graziosi
@ 2017-09-14 0:59 ` Paul Eggert
2017-09-14 1:14 ` Mark Oteiza
2017-09-14 2:41 ` Eli Zaretskii
1 sibling, 1 reply; 8+ messages in thread
From: Paul Eggert @ 2017-09-14 0:59 UTC (permalink / raw)
To: Angelo Graziosi; +Cc: Mark Oteiza, emacs-devel
On 09/13/2017 02:54 PM, Angelo Graziosi wrote:
> Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
I'm not seeing any problem on Fedora 26 x86-64. configure.ac does have
this bit:
## ???
if test "${opsys}" = "mingw32"; then
LIBLCMS2=
fi
and the "???" suggests that the patch hasn't been ported to MingW yet.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-14 0:59 ` Paul Eggert
@ 2017-09-14 1:14 ` Mark Oteiza
0 siblings, 0 replies; 8+ messages in thread
From: Mark Oteiza @ 2017-09-14 1:14 UTC (permalink / raw)
To: Paul Eggert; +Cc: Angelo Graziosi, emacs-devel
On 13/09/17 at 05:59pm, Paul Eggert wrote:
> On 09/13/2017 02:54 PM, Angelo Graziosi wrote:
> > Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
>
> I'm not seeing any problem on Fedora 26 x86-64. configure.ac does have this
> bit:
>
> ## ???
> if test "${opsys}" = "mingw32"; then
> LIBLCMS2=
> fi
>
> and the "???" suggests that the patch hasn't been ported to MingW yet.
That is correct. Sorry, I didn't know the above would break
things--looked like a noop to me reading it elsewhere in configure.ac
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-13 21:54 Emacs master broken Angelo Graziosi
2017-09-14 0:59 ` Paul Eggert
@ 2017-09-14 2:41 ` Eli Zaretskii
2017-09-14 16:50 ` Eli Zaretskii
2017-09-14 18:57 ` Andy Moreton
1 sibling, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2017-09-14 2:41 UTC (permalink / raw)
To: Angelo Graziosi; +Cc: emacs-devel
> Date: Wed, 13 Sep 2017 23:54:28 +0200 (CEST)
> From: Angelo Graziosi <angelo.g0@libero.it>
>
> Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
>
> Angelo
>
> [...]
> GEN ../../lisp/international/cp51932.el
> GEN ../../lisp/international/eucjp-ms.el
> GEN charsets.stamp
> make[2]: uscita dalla directory "/tmp/emacs-master/admin/charsets"
> make -C ../admin/unidata charscript.el
> make[2]: ingresso nella directory "/tmp/emacs-master/admin/unidata"
> GEN ../../lisp/international/charscript.el
> make[2]: uscita dalla directory "/tmp/emacs-master/admin/unidata"
> CCLD temacs.exe
> lcms.o:lcms.c:(.text+0x196): undefined reference to `cmsCIE2000DeltaE'
> lcms.o:lcms.c:(.text+0x196): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIE2000DeltaE'
This feature is not yet supported on Windows, so you will have to
build with --without-lcms2 for the time being.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-14 2:41 ` Eli Zaretskii
@ 2017-09-14 16:50 ` Eli Zaretskii
2017-09-14 20:26 ` Angelo Graziosi
2017-09-14 18:57 ` Andy Moreton
1 sibling, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2017-09-14 16:50 UTC (permalink / raw)
To: angelo.g0; +Cc: emacs-devel
> Date: Thu, 14 Sep 2017 05:41:06 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> > Date: Wed, 13 Sep 2017 23:54:28 +0200 (CEST)
> > From: Angelo Graziosi <angelo.g0@libero.it>
> >
> > Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
> >
> > Angelo
> >
> > [...]
> > GEN ../../lisp/international/cp51932.el
> > GEN ../../lisp/international/eucjp-ms.el
> > GEN charsets.stamp
> > make[2]: uscita dalla directory "/tmp/emacs-master/admin/charsets"
> > make -C ../admin/unidata charscript.el
> > make[2]: ingresso nella directory "/tmp/emacs-master/admin/unidata"
> > GEN ../../lisp/international/charscript.el
> > make[2]: uscita dalla directory "/tmp/emacs-master/admin/unidata"
> > CCLD temacs.exe
> > lcms.o:lcms.c:(.text+0x196): undefined reference to `cmsCIE2000DeltaE'
> > lcms.o:lcms.c:(.text+0x196): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIE2000DeltaE'
Should be fixed now.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-14 2:41 ` Eli Zaretskii
2017-09-14 16:50 ` Eli Zaretskii
@ 2017-09-14 18:57 ` Andy Moreton
2017-09-14 19:24 ` Eli Zaretskii
1 sibling, 1 reply; 8+ messages in thread
From: Andy Moreton @ 2017-09-14 18:57 UTC (permalink / raw)
To: emacs-devel
On Thu 14 Sep 2017, Eli Zaretskii wrote:
>> Date: Wed, 13 Sep 2017 23:54:28 +0200 (CEST)
>> From: Angelo Graziosi <angelo.g0@libero.it>
>>
>> Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
>>
>> Angelo
>>
>> [...]
>> GEN ../../lisp/international/cp51932.el
>> GEN ../../lisp/international/eucjp-ms.el
>> GEN charsets.stamp
>> make[2]: uscita dalla directory "/tmp/emacs-master/admin/charsets"
>> make -C ../admin/unidata charscript.el
>> make[2]: ingresso nella directory "/tmp/emacs-master/admin/unidata"
>> GEN ../../lisp/international/charscript.el
>> make[2]: uscita dalla directory "/tmp/emacs-master/admin/unidata"
>> CCLD temacs.exe
>> lcms.o:lcms.c:(.text+0x196): undefined reference to `cmsCIE2000DeltaE'
>> lcms.o:lcms.c:(.text+0x196): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIE2000DeltaE'
>
> This feature is not yet supported on Windows, so you will have to
> build with --without-lcms2 for the time being.
Configure does not seem to support --with-lcms2 or --without-lcms2
options yet.
configure: WARNING: unrecognized options: --with-lcms2
It looks like configure.ac is missing an OPTION_DEFAULT_ON(lcms2) or
OPTION_DEFAULT_OFF(lcms2) stanza. Perhaps someone with the necessary
autotools knowledge can add that.
AndyM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-14 18:57 ` Andy Moreton
@ 2017-09-14 19:24 ` Eli Zaretskii
0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2017-09-14 19:24 UTC (permalink / raw)
To: Andy Moreton; +Cc: emacs-devel
> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Thu, 14 Sep 2017 19:57:01 +0100
>
> Configure does not seem to support --with-lcms2 or --without-lcms2
> options yet.
>
> configure: WARNING: unrecognized options: --with-lcms2
>
> It looks like configure.ac is missing an OPTION_DEFAULT_ON(lcms2) or
> OPTION_DEFAULT_OFF(lcms2) stanza. Perhaps someone with the necessary
> autotools knowledge can add that.
Done.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Emacs master broken
2017-09-14 16:50 ` Eli Zaretskii
@ 2017-09-14 20:26 ` Angelo Graziosi
0 siblings, 0 replies; 8+ messages in thread
From: Angelo Graziosi @ 2017-09-14 20:26 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> Il 14 settembre 2017 alle 18.50 Eli Zaretskii <eliz@gnu.org> ha scritto:
>
>
> > Date: Thu, 14 Sep 2017 05:41:06 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: emacs-devel@gnu.org
> >
> > > Date: Wed, 13 Sep 2017 23:54:28 +0200 (CEST)
> > > From: Angelo Graziosi <angelo.g0@libero.it>
> > >
> > > Indeed on MSYS2/MinGW64 I see the following (but, maybe, it is general).
> > >
> > > Angelo
> > >
> > > [...]
> > > GEN ../../lisp/international/cp51932.el
> > > GEN ../../lisp/international/eucjp-ms.el
> > > GEN charsets.stamp
> > > make[2]: uscita dalla directory "/tmp/emacs-master/admin/charsets"
> > > make -C ../admin/unidata charscript.el
> > > make[2]: ingresso nella directory "/tmp/emacs-master/admin/unidata"
> > > GEN ../../lisp/international/charscript.el
> > > make[2]: uscita dalla directory "/tmp/emacs-master/admin/unidata"
> > > CCLD temacs.exe
> > > lcms.o:lcms.c:(.text+0x196): undefined reference to `cmsCIE2000DeltaE'
> > > lcms.o:lcms.c:(.text+0x196): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `cmsCIE2000DeltaE'
>
> Should be fixed now.
Yes, it is.
Thanks,
Angelo.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-14 20:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-13 21:54 Emacs master broken Angelo Graziosi
2017-09-14 0:59 ` Paul Eggert
2017-09-14 1:14 ` Mark Oteiza
2017-09-14 2:41 ` Eli Zaretskii
2017-09-14 16:50 ` Eli Zaretskii
2017-09-14 20:26 ` Angelo Graziosi
2017-09-14 18:57 ` Andy Moreton
2017-09-14 19:24 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).