unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers
Date: Fri, 22 Sep 2017 20:21:03 +0300	[thread overview]
Message-ID: <83bmm2d4zk.fsf@gnu.org> (raw)
In-Reply-To: <87d16iivcx.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Fri, 22 Sep 2017 08:52:30 -0700)

> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Fri, 22 Sep 2017 08:52:30 -0700
> 
> (and pred
>      (progn
>        (set-buffer buffer)
>        (and buffer-offer-save (> (buffer-size) 0))))
> 
> Unless a user has customized `save-some-buffers-default-predicate', PRED
> is only t when Emacs is exiting.
> 
> I don't understand why it's being used this way, or why
> `save-some-buffers' should behave differently when called interactively
> vs when Emacs is exiting, but I didn't want to touch it because, as has
> been pointed out, it's been this way for decades.

Does VCS history explain why PRED is used like that?



  parent reply	other threads:[~2017-09-22 17:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170918202953.21378.63492@vcs0.savannah.gnu.org>
     [not found] ` <20170918202955.5043420AC4@vcs0.savannah.gnu.org>
2017-09-19  2:44   ` [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Stefan Monnier
2017-09-19  3:12     ` Eric Abrahamsen
2017-09-19 12:42       ` Stefan Monnier
2017-09-19 13:25         ` Kaushal Modi
2017-09-19 15:44           ` Eric Abrahamsen
2017-09-19 15:50             ` Kaushal Modi
2017-09-19 15:53             ` Stefan Monnier
2017-09-19 16:03               ` Eric Abrahamsen
2017-09-19 15:37         ` Leo Liu
2017-09-19 15:56           ` Stefan Monnier
2017-09-19 10:48     ` Kaushal Modi
2017-09-19 12:08       ` Stefan Monnier
2017-09-19 12:26         ` Kaushal Modi
2017-09-19 18:13           ` Eric Abrahamsen
2017-09-20  2:10             ` Kaushal Modi
2017-09-20  7:16               ` Andreas Schwab
2017-09-20 17:14               ` Eric Abrahamsen
2017-09-21  8:01                 ` Eli Zaretskii
2017-09-21 19:57                   ` Eric Abrahamsen
2017-09-21 20:10                     ` Kaushal Modi
2017-09-21 22:53                       ` Eric Abrahamsen
2017-09-22  6:54                     ` Eli Zaretskii
2017-09-22 15:52                       ` Eric Abrahamsen
2017-09-22 16:18                         ` Stefan Monnier
2017-09-22 16:54                           ` Eric Abrahamsen
2017-09-22 19:03                             ` Stefan Monnier
2017-09-22 23:27                               ` Eric Abrahamsen
2017-09-23  2:43                                 ` Stefan Monnier
2017-09-24 19:25                           ` Eric Abrahamsen
2017-09-24 19:29                             ` Stefan Monnier
2017-09-24 20:59                               ` Eric Abrahamsen
2017-09-22 17:21                         ` Eli Zaretskii [this message]
2017-09-22 17:57                           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bmm2d4zk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).