From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Wed, 14 Feb 2018 18:18:56 +0200 Message-ID: <83bmgry26n.fsf@gnu.org> References: <1775923222.898447.1518559575706@mail.libero.it> <277032065.898859.1518560883271@mail.libero.it> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518625440 1689 195.159.176.226 (14 Feb 2018 16:24:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Feb 2018 16:24:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Angelo Graziosi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 14 17:23:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elzqO-0007bv-DV for ged-emacs-devel@m.gmane.org; Wed, 14 Feb 2018 17:23:40 +0100 Original-Received: from localhost ([::1]:36825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elzsP-00017X-KF for ged-emacs-devel@m.gmane.org; Wed, 14 Feb 2018 11:25:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elzly-0003ri-9m for emacs-devel@gnu.org; Wed, 14 Feb 2018 11:19:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elzlv-0004H1-5p for emacs-devel@gnu.org; Wed, 14 Feb 2018 11:19:06 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elzlv-0004Go-2b; Wed, 14 Feb 2018 11:19:03 -0500 Original-Received: from [176.228.60.248] (port=1089 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1elzlu-0007NC-CP; Wed, 14 Feb 2018 11:19:02 -0500 In-reply-to: <277032065.898859.1518560883271@mail.libero.it> (message from Angelo Graziosi on Tue, 13 Feb 2018 23:28:03 +0100 (CET)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222742 Archived-At: > Date: Tue, 13 Feb 2018 23:28:03 +0100 (CET) > From: Angelo Graziosi > > pdumper.c: In function 'dump_read_all': > pdumper.c:4723:45: error: conversion to 'unsigned int' from 'size_t {aka long long unsigned int}' may alter its value [-Werror=conversion] > read (fd, (char*) buf + bytes_read, bytes_to_read - bytes_read); > ^~~~~~~~~~~~~ This is because the MS-Windows version of 'read' has 'unsigned int' as its last argument. But now I wonder why you don't see the same problem in sysdep.c, where emacs_read does something very similar. Not sure what am I missing here.