From: Eli Zaretskii <eliz@gnu.org>
To: Radon Rosborough <radon.neon@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix `early-init-file' value when file is missing
Date: Fri, 08 Feb 2019 09:32:55 +0200 [thread overview]
Message-ID: <83bm3mrazc.fsf@gnu.org> (raw)
In-Reply-To: <CADB4rJGgX1Gp+EVrmT3eorwaV8ANr4fy+mJUyTT0it+fBDL20Q@mail.gmail.com> (message from Radon Rosborough on Fri, 1 Feb 2019 15:10:24 -0800)
> From: Radon Rosborough <radon.neon@gmail.com>
> Date: Fri, 1 Feb 2019 15:10:24 -0800
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> > This patch has the (possibly unintended) consequence that if ~/.emacs
> > doesn't exist, user-init-file is set to "~/.emacs.el", something I
> > don't think we want. Can you propose a change that will affect only
> > early-init-file, not any other init file?
>
> Sure, no problem. I apologize for the oversight.
>
> A revised patch which implements the same bugfix without changing the
> value of `user-init-file' is attached.
>
> Previously, if no early init-file existed in `user-emacs-directory',
> then the value of `early-init-file' after startup would be
> ~/.emacs.d/early-init (note the missing extension). This commit
> adjusts that value to ~/.emacs.d/early-init.el as desired, while not
> changing other behavior. Note that when the early init-file did
> exist, then the value of `early-init-file' after startup was already
> correct; this commit fixes a bug that occurred only when the file did
> not exist.
>
> lisp/startup.el (load-user-init-file): Update logic.
Thanks. However, I would prefer to have this solved outside
load-user-init-file, if feasible. This function is too central to
Emacs to make non-trivial changes there for such a minor problem's
sake. Especially since we don't have a test suite for startup
functionalities. I think the change outside of the function will also
be much simpler and thus easier to grasp.
next prev parent reply other threads:[~2019-02-08 7:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 5:54 [PATCH] Fix `early-init-file' value when file is missing Radon Rosborough
2019-01-23 3:47 ` Radon Rosborough
2019-01-29 17:24 ` Radon Rosborough
2019-01-29 17:46 ` Eli Zaretskii
2019-02-01 9:11 ` Eli Zaretskii
2019-02-01 23:10 ` Radon Rosborough
2019-02-08 7:32 ` Eli Zaretskii [this message]
2019-02-08 17:34 ` Radon Rosborough
2019-02-08 21:52 ` Eli Zaretskii
2019-02-10 23:04 ` Radon Rosborough
2019-02-10 23:14 ` Stefan Monnier
2019-02-11 16:05 ` Eli Zaretskii
2019-02-12 5:38 ` Radon Rosborough
2019-02-12 16:14 ` Eli Zaretskii
2019-02-13 2:36 ` Radon Rosborough
2019-02-13 17:56 ` Eli Zaretskii
2019-02-16 0:47 ` Radon Rosborough
2019-02-16 7:17 ` Eli Zaretskii
2019-02-16 20:26 ` Radon Rosborough
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bm3mrazc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=radon.neon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).