From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: arc-mode Date: Sat, 18 May 2019 10:50:05 +0300 Message-ID: <83bm009p76.fsf@gnu.org> References: <83d0khb888.fsf@gnu.org> <83lfz49v8r.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="45114"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 09:50:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRu6k-000BZB-La for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 09:50:18 +0200 Original-Received: from localhost ([127.0.0.1]:59007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRu6j-0006LL-Fy for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 03:50:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRu6d-0006JA-QQ for emacs-devel@gnu.org; Sat, 18 May 2019 03:50:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRu6d-0000wb-Mk; Sat, 18 May 2019 03:50:11 -0400 Original-Received: from [176.228.60.248] (port=3163 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hRu6c-0000G1-Th; Sat, 18 May 2019 03:50:11 -0400 In-reply-to: (message from Lars Ingebrigtsen on Sat, 18 May 2019 08:04:25 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236705 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Sat, 18 May 2019 08:04:25 +0200 > > There's one additional use of string-as-multibyte in arc-mode that I > didn't notice before: > > (defun archive-l-e (str &optional len) > "Convert little endian string/vector STR to integer. > Alternatively, STR may be a buffer position in the current buffer > in which case a second argument, length LEN, should be supplied." > (if (stringp str) > (setq len (length str)) > (setq str (buffer-substring str (+ str len)))) > (setq str (string-as-unibyte str)) > (let ((result 0) > (i 0)) > (while (< i len) > (setq i (1+ i) > result (+ (ash result 8) > (aref str (- len i))))) > result)) I think using this instead of string-as-unibyte should be OK: (if (multibyte-string-p str) (setq str (encode-coding-string str 'utf-8-emacs-unix))) What string-as-unibyte does is it makes a unibyte string with the same bytes as the internal representation of STR, except for raw bytes, which it converts to their external single-byte form. Encoding with utf-8-emacs does the same.