From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: so-long tests Date: Sat, 13 Jul 2019 13:01:55 +0300 Message-ID: <83blxy1cdo.fsf@gnu.org> References: <83sgra1jn6.fsf@gnu.org> <1046d298-c0bc-a69f-39a7-011aa993c9da@orcon.net.nz> <83k1cm1h49.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46764"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 13 12:09:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmEyP-000C31-2g for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 12:09:45 +0200 Original-Received: from localhost ([::1]:54374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmEr0-0003mo-Sw for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 06:02:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60334) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmEqy-0003mg-35 for emacs-devel@gnu.org; Sat, 13 Jul 2019 06:02:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmEqw-0004lX-Kr; Sat, 13 Jul 2019 06:02:02 -0400 Original-Received: from [176.228.60.248] (port=4400 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmEqv-0005iq-HF; Sat, 13 Jul 2019 06:02:02 -0400 In-reply-to: (message from Phil Sainty on Sat, 13 Jul 2019 21:41:10 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238551 Archived-At: > Cc: emacs-devel@gnu.org > From: Phil Sainty > Date: Sat, 13 Jul 2019 21:41:10 +1200 > > > Why do we need the exception in this case? Exceptions should > > be reserved for exceptional cases. > > The reason I used that directory structure is that I ended up > using multiple test files. My initial tests were indeed written > as a test/lisp/so-long-tests.el file, but I switched to the > alternative structure when I added additional files. If you'd like to keep the tests on separate files, it's fine with me, but please add a comment somewhere for why these tests are in a subdirectory. The inconvenient part of this arrangement is that I at least am in the habit of typing "make lisp/foo-tests TAB" in the test/ directory after making any changes to lisp/foo.el, and I normally take the lack of completion to mean there are no tests for foo.el. Having to remember to look in subdirectories is a burden. It is up to you to decide whether your motivation for keeping separate test files is more important than that.