unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: emacs-devel@gnu.org
Subject: Re: so-long tests
Date: Sat, 13 Jul 2019 13:01:55 +0300	[thread overview]
Message-ID: <83blxy1cdo.fsf@gnu.org> (raw)
In-Reply-To: <a1c00a8f-fbd0-3eea-8cbb-e29321758917@orcon.net.nz> (message from Phil Sainty on Sat, 13 Jul 2019 21:41:10 +1200)

> Cc: emacs-devel@gnu.org
> From: Phil Sainty <psainty@orcon.net.nz>
> Date: Sat, 13 Jul 2019 21:41:10 +1200
> 
> > Why do we need the exception in this case?  Exceptions should
> > be reserved for exceptional cases.
> 
> The reason I used that directory structure is that I ended up
> using multiple test files.  My initial tests were indeed written
> as a test/lisp/so-long-tests.el file, but I switched to the
> alternative structure when I added additional files.

If you'd like to keep the tests on separate files, it's fine with me,
but please add a comment somewhere for why these tests are in a
subdirectory.

The inconvenient part of this arrangement is that I at least am in the
habit of typing "make lisp/foo-tests TAB" in the test/ directory after
making any changes to lisp/foo.el, and I normally take the lack of
completion to mean there are no tests for foo.el.  Having to remember
to look in subdirectories is a burden.  It is up to you to decide
whether your motivation for keeping separate test files is more
important than that.



  reply	other threads:[~2019-07-13 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-13  7:25 so-long tests Eli Zaretskii
2019-07-13  8:08 ` Phil Sainty
2019-07-13  8:19   ` Eli Zaretskii
2019-07-13  9:41     ` Phil Sainty
2019-07-13 10:01       ` Eli Zaretskii [this message]
2019-07-13 10:25         ` Phil Sainty
2019-07-13 14:40         ` phillip.lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83blxy1cdo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).