From: Eli Zaretskii <eliz@gnu.org>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: policy regarding DEFUNs in subr-x.el
Date: Sun, 22 Mar 2020 19:12:43 +0200 [thread overview]
Message-ID: <83bloocnzo.fsf@gnu.org> (raw)
In-Reply-To: <87d0945r4z.fsf@gmail.com> (message from Štěpán Němec on Sun, 22 Mar 2020 16:46:36 +0100)
> From: Štěpán Němec <stepnem@gmail.com>
> Date: Sun, 22 Mar 2020 16:46:36 +0100
>
> Now, it does seem sensible for the function to be a normal, not inline,
> function, but what about the commentary and all the other defsubsts,
> including the other string utilities?
>
> If the no-defun policy should be changed, or if I was mistaken in
> believing there was one to begin with, shouldn't the commentary
> recommending compile-time usage be removed, and at least some of the
> other defsubsts turned into defuns, too?
I don't see that the commentary says the code in this file must be
inline. If something in the wording implies that, let's change the
wording so that it doesn't.
From my POV, there's no reason to require that everything in that file
is inlined, and that single "outlier" is the evidence.
next prev parent reply other threads:[~2020-03-22 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 15:46 policy regarding DEFUNs in subr-x.el Štěpán Němec
2020-03-22 17:12 ` Eli Zaretskii [this message]
2020-03-22 20:38 ` Tassilo Horn
2020-03-28 14:20 ` Štěpán Němec
2020-03-28 14:35 ` Eli Zaretskii
2020-03-28 14:47 ` Štěpán Němec
2020-03-28 14:50 ` Štěpán Němec
2020-03-28 15:04 ` Eli Zaretskii
2020-03-28 15:31 ` Štěpán Němec
2020-03-28 15:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bloocnzo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).