From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making TTY menus more visual Date: Sun, 04 Oct 2020 09:22:08 +0300 Message-ID: <83blhifr3j.fsf@gnu.org> References: <087df85a965fac6555a755c1bbebf1ea@finder.org> <83r1qhf5ii.fsf@gnu.org> <83wo07g0bf.fsf@gnu.org> <85afa5c0a0a789c6047e92f6ecfa9fcc@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8666"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jared Finder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 04 08:23:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOxQE-00027K-Ri for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Oct 2020 08:23:02 +0200 Original-Received: from localhost ([::1]:54440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOxQD-0000PD-RG for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Oct 2020 02:23:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOxPP-0008Np-8i for emacs-devel@gnu.org; Sun, 04 Oct 2020 02:22:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37168) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOxPO-0000oo-Bh; Sun, 04 Oct 2020 02:22:10 -0400 Original-Received: from [176.228.60.248] (port=3388 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kOxPN-0004Ec-RA; Sun, 04 Oct 2020 02:22:10 -0400 In-Reply-To: <85afa5c0a0a789c6047e92f6ecfa9fcc@finder.org> (message from Jared Finder on Sat, 03 Oct 2020 12:26:49 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257009 Archived-At: > Date: Sat, 03 Oct 2020 12:26:49 -0700 > From: Jared Finder > Cc: emacs-devel@gnu.org > > >> 1. Add a new command that calls menu-bar-open with the right value for > >> initial-x. (this is the patch 001 in the root of the thread) > > > > But patch 001 also includes unrelated parts, the tmm-menubar-item-at-x > > function etc., right? > > tmm-menubar-item-at-x is a new function to share the conversion of a > mouse X to a specific menu item between tmm-menubar and the newly added > command, menu-bar-open-mouse. > > There's no new code there, it's the existing logic in tmm-menubar. OK, but then this function should be in menu-bar.el, and its name shouldn't begin with "tmm-". tmm-menubar.el will then use it. > > This should already work; it does in the MS-Windows build when Emacs > > is invoked with -nw. Please tell more why you think any changes there > > are needed. Perhaps you could take me through the code there and > > explain what is missing and why. (And why do you call posn-x-y in the > > patch when X and Y are already known and used by that code? is that > > because mouse_get_xy does not yet support xterm-mouse? if so, that > > support should be added via the terminal's mouse_position_hook.) > > From injecting debug logs into read_menu_input, I can observe that > tty-menu-mouse-movement is never received so the highlighted item never > changes except due to keyboard input. And from tracing > xterm-mouse--read-event-sequence, it appears that Emacs normally does > not receive xterm mouse motion events unless a button is pressed. > > This appears to be due to xt-mouse sending event code 1002 instead of > 1003 (see > https://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-Mouse-Tracking). > > Just sending 1003 instead doesn't just work, but I do see mouse events > now coming through. Let me do some more investigation here and I will > get back to you. Thanks.