From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Mouse-hovering over 'mouse-face' overlays/regions on a TTY Emacs Date: Sat, 05 Dec 2020 12:39:50 +0200 Message-ID: <83blf8cz9l.fsf@gnu.org> References: <838sajle0s.fsf@gnu.org> <83v9dmker4.fsf@gnu.org> <83h7p6kd74.fsf@gnu.org> <837dq2k8ik.fsf@gnu.org> <87eekag0n3.fsf@gmail.com> <83zh2yisdt.fsf@gnu.org> <83o8jdgzgk.fsf@gnu.org> <5aff1d6ff795552203292395560a5075@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39848"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, emacs-devel@gnu.org To: Jared Finder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 05 11:41:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klV00-000AEm-Jh for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Dec 2020 11:41:08 +0100 Original-Received: from localhost ([::1]:32942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klUzz-0000eh-HT for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Dec 2020 05:41:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klUz0-00006N-Tp for emacs-devel@gnu.org; Sat, 05 Dec 2020 05:40:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43755) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klUz0-000592-Bl; Sat, 05 Dec 2020 05:40:06 -0500 Original-Received: from [176.228.60.248] (port=3131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1klUyz-0004vV-IK; Sat, 05 Dec 2020 05:40:06 -0500 In-Reply-To: <5aff1d6ff795552203292395560a5075@finder.org> (message from Jared Finder on Wed, 02 Dec 2020 00:40:01 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260349 Archived-At: > Date: Wed, 02 Dec 2020 00:40:01 -0800 > From: Jared Finder > Cc: joaotavora@gmail.com, emacs-devel@gnu.org > > * src/frame.c (Fset_mouse_position, Fset_mouse_pixel_position): Call > Fselect_frame in all terminals, independent of defines. Maybe I'm missing something, but I don't see how the proposed changes cause Fselect_frame to be called fore any display type. > diff --git a/src/frame.c b/src/frame.c > index 17ec455d2d..4bbcb74667 100644 > --- a/src/frame.c > +++ b/src/frame.c > @@ -2574,22 +2574,28 @@ DEFUN ("set-mouse-position", Fset_mouse_position, Sset_mouse_position, 3, 3, 0, > /* I think this should be done with a hook. */ > #ifdef HAVE_WINDOW_SYSTEM > if (FRAME_WINDOW_P (XFRAME (frame))) > - /* Warping the mouse will cause enternotify and focus events. */ > - frame_set_mouse_position (XFRAME (frame), xval, yval); > -#elif defined MSDOS > + { > + /* Warping the mouse will cause enternotify and focus events. */ > + frame_set_mouse_position (XFRAME (frame), xval, yval); > + return Qnil; > + } > +#endif /* HAVE_WINDOW_SYSTEM */ > +#ifdef MSDOS > if (FRAME_MSDOS_P (XFRAME (frame))) > { > Fselect_frame (frame, Qnil); > mouse_moveto (xval, yval); > + return Qnil; > } Can we do this without introducing multiple return points? if nothing else, that makes it harder to assess correctness and harder to debug the code. > +#if defined (HAVE_GPM) && ! defined (HAVE_WINDOW_SYSTEM) > term_mouse_moveto (xval, yval); > #else The additional HAVE_WINDOW_SYSTEM condition is because term_mouse_moveto is conditioned the same on term.c? If so, I think we should remove the HAVE_WINDOW_SYSTEM part there as well: there's no reason why a --with-x build couldn't also support GPM. Thanks.