From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 64f2c96 2/2: Make a process test faster.
Date: Sun, 10 Jan 2021 18:39:30 +0200
Message-ID: <83bldwhhkt.fsf@gnu.org>
References: <20210102125533.3832.43853@vcs0.savannah.gnu.org>
 <20210102125536.C3FED2094D@vcs0.savannah.gnu.org>
 <elmtxprk8u.fsf@fencepost.gnu.org>
 <CAArVCkQyQzd3MwD0bH1c6ZQTt72zZTQs_47=o0eK51c54NLpiw@mail.gmail.com>
 <CAP-RRPsj9eashnHc7goLG21F-S96-uHGdjgUQOtCXy4-RkOSWw@mail.gmail.com>
 <iz35zcgqc2.fsf@fencepost.gnu.org>
 <CAArVCkRaZ+DiVnfZOG8hcHbPf2xEHOE25EZs1tt=niBSf6MP4Q@mail.gmail.com>
 <CAArVCkQDj6_dJ6PdK95VAT5R_t-5H3wVTKxEPKPKygmrPkHWRw@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="40243"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: phst@google.com, rgm@gnu.org, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 10 17:40:34 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kydla-000ANc-FW
	for ged-emacs-devel@m.gmane-mx.org; Sun, 10 Jan 2021 17:40:34 +0100
Original-Received: from localhost ([::1]:34474 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kydlZ-0004OC-K8
	for ged-emacs-devel@m.gmane-mx.org; Sun, 10 Jan 2021 11:40:33 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59626)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kydkS-0003wr-2r
 for emacs-devel@gnu.org; Sun, 10 Jan 2021 11:39:24 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49617)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kydkR-0006hH-QH; Sun, 10 Jan 2021 11:39:23 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1560
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kydkQ-0002q0-2j; Sun, 10 Jan 2021 11:39:23 -0500
In-Reply-To: <CAArVCkQDj6_dJ6PdK95VAT5R_t-5H3wVTKxEPKPKygmrPkHWRw@mail.gmail.com>
 (message from Philipp Stephani on Sat, 9 Jan 2021 22:00:45 +0100)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:262854
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/262854>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 9 Jan 2021 22:00:45 +0100
> Cc: Philipp Stephani <phst@google.com>, Emacs developers <emacs-devel@gnu.org>
> 2. The other one happens if SIGCHLD is signaled during
> wait_reading_process_output. Then wait_reading_process_output will
> wait forever, since the stdout FD never gets closed and it doesn't see
> the process status update in time.

Do you mean that wait_reading_process_output has this problem in
general, or just in this particular scenario?  If the former, I'm
surprised, as we are using this code for a very long time.  If the
latter, can you elaborate on the situation, and what does SIGCHLD have
to do with closing stdout?