From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Wed, 24 Feb 2021 18:46:08 +0200 Message-ID: <83blc9tnvz.fsf@gnu.org> References: <87h7m5iagw.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34173"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 24 17:48:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lExKT-0008lJ-5z for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Feb 2021 17:48:01 +0100 Original-Received: from localhost ([::1]:42146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lExKS-0004T5-1n for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Feb 2021 11:48:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lExIv-0003sf-6B for emacs-devel@gnu.org; Wed, 24 Feb 2021 11:46:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37285) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lExIu-0003CT-H6; Wed, 24 Feb 2021 11:46:24 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4133 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lExIt-00017o-SW; Wed, 24 Feb 2021 11:46:24 -0500 In-Reply-To: (message from Stefan Kangas on Tue, 23 Feb 2021 19:40:07 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265581 Archived-At: > From: Stefan Kangas > Date: Tue, 23 Feb 2021 19:40:07 -0600 > Cc: emacs-devel@gnu.org > > So I have made `substitute-command-keys' add this face unconditionally > to keys. > > Having looked over the 430 matches for s-c-k in our tree, I couldn't > find any location where we would not benefit from this consistency. What about tooltips? we run their text through substitute-command-keys, AFAIR, but the tooltip's faces need to use smaller fonts. So at the very least this face should be documented to affect only some of the face attributes, not all of them (which is generally not such a good idea, as it confuses users).