unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master ac6b62b: * lisp/time.el (world-clock-mode): Make non-interactive.
Date: Fri, 23 Apr 2021 14:25:37 +0300	[thread overview]
Message-ID: <83bla5nsy6.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmm3iYre=Vuq+P3C8O0Dg_UsCQpNQuOgcnLwdt9E5tcEFw@mail.gmail.com> (message from Stefan Kangas on Fri, 23 Apr 2021 10:58:24 +0000)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 23 Apr 2021 10:58:24 +0000
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> This mode is only useful in a buffer prepared for its use by
> >> `world-clock'.  Running it in an arbitrary buffer will silently fail.
> >
> > Is that true also for turning off the mode?
> 
> I don't think I understand the question: AFAIK, you can't turn off a
> major mode (see `(elisp) Major Modes').  But you can of course still
> switch to a different major mode with or without this change.

Before your change, I could turn on this mode interactively in a
buffer which was already formatted (e.g., by copy/paste from another
such buffer, or in the original *wclock* buffer, if I switched to
another major mode in it).  With this change, doing that is no longer
possible.  So I think the least we need is to mention that in NEWS.

IOW, it's a user-visible change, whether we think the previous
functionality was useful or not.



  reply	other threads:[~2021-04-23 11:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  6:09 master ac6b62b: * lisp/time.el (world-clock-mode): Make non-interactive Eli Zaretskii
2021-04-23  9:22 ` Stefan Kangas
2021-04-23 10:34   ` Eli Zaretskii
2021-04-23 10:58     ` Stefan Kangas
2021-04-23 11:25       ` Eli Zaretskii [this message]
2021-04-23 12:34         ` Stefan Kangas
2021-04-23 13:03           ` Eli Zaretskii
2021-04-23 13:01         ` Stefan Kangas
2021-04-23 13:17           ` Eli Zaretskii
2021-04-23 13:36             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bla5nsy6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).