From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [patch] * lisp/international/mule-cmds.el
 (deactivate-input-method): Tiny improve.
Date: Wed, 28 Apr 2021 14:54:00 +0300
Message-ID: <83bl9yhbfr.fsf@gnu.org>
References: <72dd9740.3f2c.179175d9a8d.Coremail.tumashu@163.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="11591"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: tumashu <tumashu@163.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 28 13:54:47 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lbimF-0002vC-9d
	for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Apr 2021 13:54:47 +0200
Original-Received: from localhost ([::1]:33040 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lbimE-0002A7-CT
	for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Apr 2021 07:54:46 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49588)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lbilh-0001kC-HV
 for emacs-devel@gnu.org; Wed, 28 Apr 2021 07:54:13 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41695)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lbilf-00028w-IN; Wed, 28 Apr 2021 07:54:11 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1118
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lbile-0007ma-Uy; Wed, 28 Apr 2021 07:54:11 -0400
In-Reply-To: <72dd9740.3f2c.179175d9a8d.Coremail.tumashu@163.com> (message
 from tumashu on Wed, 28 Apr 2021 15:24:40 +0800 (CST))
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:268563
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/268563>

> Date: Wed, 28 Apr 2021 15:24:40 +0800 (CST)
> From: tumashu <tumashu@163.com>
> 
> --- a/lisp/international/mule-cmds.el
> +++ b/lisp/international/mule-cmds.el
> @@ -1500,7 +1500,8 @@ deactivate-input-method
>  	(progn
>  	  (setq input-method-function nil
>  		current-input-method-title nil)
> -	  (funcall deactivate-current-input-method-function))
> +          (when (functionp deactivate-current-input-method-function)
> +	    (funcall deactivate-current-input-method-function)))

Thanks, but could you please explain why this is needed?  IOW, in
which use case did you see this function called when
deactivate-current-input-method-function wasn't a function?