From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add an option to not reduce vocabulary of the Japanese Date: Sat, 04 Jun 2022 16:43:42 +0300 Message-ID: <83bkv8bl2p.fsf@gnu.org> References: <87r146o2rt.fsf@taiju.info> <8335gme0ml.fsf@gnu.org> <87a6auz1p4.fsf@taiju.info> <83pmjqc89p.fsf@gnu.org> <87sfolwyzj.fsf@taiju.info> <83ee04bz70.fsf@gnu.org> <87h750tzwh.fsf@taiju.info> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="476"; mail-complaints-to="usenet@ciao.gmane.io" Cc: handa@gnu.org, emacs-devel@gnu.org To: Taiju HIGASHI Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 04 15:46:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nxU7G-000ATG-0L for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jun 2022 15:46:58 +0200 Original-Received: from localhost ([::1]:46390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxU7E-00045y-NK for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Jun 2022 09:46:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxU4H-0000sY-8e for emacs-devel@gnu.org; Sat, 04 Jun 2022 09:43:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxU4G-0006hE-TB; Sat, 04 Jun 2022 09:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Jl9CWvgtY/Tzc8ZM3HEVety6zK4DxpNnbRtKeS66eOY=; b=a7dMAT+cNb37 OlQSbwO6YANtU6doDp+YRhLw7mX9z+djmqiUZUqu/zhXk30hNfiIFl6uEtde/UkLPt/sDwpf+8L8B n/9zH4iPo35tRxoj6X03+Kofh/Q3bxvwdxexHTyxDycJ6aGCLvtOM3/pXEy4NYs8tghW1Dy0qBk4J vcQBl/ayyNN8LvjCAfVPG+ysfHJiGLNhAfbip9i7nxP48x0qGnirk7u1ix6jMgXnprS1uiNNeI6NI +HL1GqpxeBsGPLwZknwDO+TtqEI/Pea9wiZXDAMISIpBv1p4VIgWrjcl1B1C+YPFNF+cI6TNcY3ub 0k0ql+mZhTEbg736tStKaA==; Original-Received: from [87.69.77.57] (port=1519 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxU4G-00032u-2z; Sat, 04 Jun 2022 09:43:52 -0400 In-Reply-To: <87h750tzwh.fsf@taiju.info> (message from Taiju HIGASHI on Sat, 04 Jun 2022 20:46:06 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290654 Archived-At: > From: Taiju HIGASHI > Cc: handa@gnu.org, emacs-devel@gnu.org > Date: Sat, 04 Jun 2022 20:46:06 +0900 > > > I thought no changes were needed, because one could already say > > something like > > > > make ja-dic.el JA_DIC_REDUCTION='' > > > > Wouldn't that work? Perhaps in lisp/Makefile.in one should make sure > > the JA_DIC_REDUCTION value was propagated to the sub-make running in > > leim/, but that's all. > > > > Am I missing something? > > > > Thanks. > > I may not have understood it properly. > > Did you imagine that the special rules for re-generating would be > implemented in lisp/Makefile? The rules for re-generating with and without reduction should be in one place, in the same Makefile. > In that case, are you saying that there is no need to modify the > leim/Makefile? > Certainly, if that is the case, you may be right. > > For example, what about the idea of adding regenerate-ja-dic and > regenerate-ja-dic-without-reductoin as new special rules in > lisp/Makefile? I'm saying that the same rule could serve both kinds of re-generation, because the only difference is the single option passed to the Emacs invocation. We can rely on the user who want to re-generate the dictionary to supply the option manually, when invoking Make. So no separate rules should be necessary.