Re: [PATCH] Add an option to not reduce vocabulary of the Japanese

[Eli Zaretskii <eliz@gnu.org>]

> From: Taiju HIGASHI <higashi@taiju.info>
> Cc: handa@gnu.org,  emacs-devel@gnu.org
> Date: Sat, 04 Jun 2022 20:46:06 +0900
> 
> > I thought no changes were needed, because one could already say
> > something like
> >
> >   make ja-dic.el JA_DIC_REDUCTION=''
> >
> > Wouldn't that work?  Perhaps in lisp/Makefile.in one should make sure
> > the JA_DIC_REDUCTION value was propagated to the sub-make running in
> > leim/, but that's all.
> >
> > Am I missing something?
> >
> > Thanks.
> 
> I may not have understood it properly.
> 
> Did you imagine that the special rules for re-generating would be
> implemented in lisp/Makefile?

The rules for re-generating with and without reduction should be in
one place, in the same Makefile.

> In that case, are you saying that there is no need to modify the
> leim/Makefile?
> Certainly, if that is the case, you may be right.
> 
> For example, what about the idea of adding regenerate-ja-dic and
> regenerate-ja-dic-without-reductoin as new special rules in
> lisp/Makefile?

I'm saying that the same rule could serve both kinds of re-generation,
because the only difference is the single option passed to the Emacs
invocation.  We can rely on the user who want to re-generate the
dictionary to supply the option manually, when invoking Make.

So no separate rules should be necessary.