unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Taiju HIGASHI <higashi@taiju.info>
Cc: handa@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCH] Add an option to not reduce vocabulary of the Japanese
Date: Sat, 04 Jun 2022 16:43:42 +0300	[thread overview]
Message-ID: <83bkv8bl2p.fsf@gnu.org> (raw)
In-Reply-To: <87h750tzwh.fsf@taiju.info> (message from Taiju HIGASHI on Sat, 04 Jun 2022 20:46:06 +0900)

> From: Taiju HIGASHI <higashi@taiju.info>
> Cc: handa@gnu.org,  emacs-devel@gnu.org
> Date: Sat, 04 Jun 2022 20:46:06 +0900
> 
> > I thought no changes were needed, because one could already say
> > something like
> >
> >   make ja-dic.el JA_DIC_REDUCTION=''
> >
> > Wouldn't that work?  Perhaps in lisp/Makefile.in one should make sure
> > the JA_DIC_REDUCTION value was propagated to the sub-make running in
> > leim/, but that's all.
> >
> > Am I missing something?
> >
> > Thanks.
> 
> I may not have understood it properly.
> 
> Did you imagine that the special rules for re-generating would be
> implemented in lisp/Makefile?

The rules for re-generating with and without reduction should be in
one place, in the same Makefile.

> In that case, are you saying that there is no need to modify the
> leim/Makefile?
> Certainly, if that is the case, you may be right.
> 
> For example, what about the idea of adding regenerate-ja-dic and
> regenerate-ja-dic-without-reductoin as new special rules in
> lisp/Makefile?

I'm saying that the same rule could serve both kinds of re-generation,
because the only difference is the single option passed to the Emacs
invocation.  We can rely on the user who want to re-generate the
dictionary to supply the option manually, when invoking Make.

So no separate rules should be necessary.



  reply	other threads:[~2022-06-04 13:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  3:16 [PATCH] Add an option to not reduce vocabulary of the Japanese Taiju HIGASHI
2022-06-03  6:12 ` Eli Zaretskii
2022-06-03  6:43   ` Taiju HIGASHI
2022-06-03 11:10     ` Eli Zaretskii
     [not found]       ` <87sfolwyzj.fsf@taiju.info>
2022-06-04  8:38         ` Eli Zaretskii
2022-06-04 11:46           ` Taiju HIGASHI
2022-06-04 13:43             ` Eli Zaretskii [this message]
2022-06-04 16:39               ` Taiju HIGASHI
2022-06-04 16:47                 ` Eli Zaretskii
2022-06-04 17:01                   ` Taiju HIGASHI
2022-06-04 17:03                     ` Eli Zaretskii
2022-06-05  3:05                     ` handa
2022-06-05 14:07                       ` Taiju HIGASHI
2022-06-06 11:52                         ` handa
2022-06-06 12:53                           ` Taiju HIGASHI
2022-06-06 14:14                             ` Lars Ingebrigtsen
2022-06-06 14:17                               ` Eli Zaretskii
2022-06-06 15:08                                 ` Taiju HIGASHI
2022-06-06 16:05                                   ` Eli Zaretskii
2022-06-07  0:47                                     ` Taiju HIGASHI
2022-06-07  1:06                                       ` Taiju HIGASHI
2022-06-07  3:50                                         ` Taiju HIGASHI
2022-06-07 10:58                                           ` Eli Zaretskii
2022-06-07  9:36                                         ` Lars Ingebrigtsen
2022-06-07 10:10                                           ` Taiju HIGASHI
2022-06-07 10:22                                             ` Lars Ingebrigtsen
2022-06-07 10:48                                       ` Eli Zaretskii
2022-06-07 12:12                                         ` Taiju HIGASHI
2022-06-07 12:41                                         ` Taiju HIGASHI
2022-06-07 13:08                                           ` Taiju HIGASHI
2022-06-09 13:10                                             ` Taiju HIGASHI
2022-06-09 13:14                                               ` Eli Zaretskii
2022-06-10 13:15                                             ` Eli Zaretskii
2022-06-10 13:50                                               ` Taiju HIGASHI
2022-06-03 23:51     ` Richard Stallman
2022-06-04 10:57       ` Taiju HIGASHI
2022-06-04 11:19         ` Taiju HIGASHI
2022-06-05 22:53         ` Richard Stallman
2022-06-06  0:05           ` Taiju HIGASHI
2022-06-03 23:52 ` Richard Stallman
2022-06-04  6:25   ` Eli Zaretskii
2022-06-04 12:36     ` Taiju HIGASHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkv8bl2p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@gnu.org \
    --cc=higashi@taiju.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).