From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch] Avoid recording chars when reading passwords
Date: Tue, 14 Jun 2022 14:35:37 +0300 [thread overview]
Message-ID: <83bkuvtr3q.fsf@gnu.org> (raw)
In-Reply-To: <8735g7vb47.fsf@elite.giraud> (message from Manuel Giraud on Tue, 14 Jun 2022 11:38:00 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: emacs-devel@gnu.org
> Date: Tue, 14 Jun 2022 11:38:00 +0200
>
> So I digged into the log and found that `inhibit--record-char' was
> obsoleted in bd5c740419.
>
> The reason seems to be that "quail.el" was the last user of this
> variable and use it to inhibit a second recording after the first
> one. AFAIU, quail.el now have function (quail-add-unread-command-events)
> that put a copy of those events with 'no-record into
> unread-command-events to have this behaviour.
>
> I was not able to do the same when reading password (there is just one
> read_char involved), so as Eli suggested, I choose to un-obsolete
> `inhibit--record-char' and use it in `read-passwd' only.
Thanks.
Stefan, do you see any way of producing (no-record . CH) from "normal"
input APIs, for reading input that shouldn't be echoed or recorded?
If not, we will resurrect that variable and use it instead.
next prev parent reply other threads:[~2022-06-14 11:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 13:46 [Patch] Avoid recording chars when reading passwords Manuel Giraud
2022-06-08 15:48 ` Eli Zaretskii
2022-06-13 13:26 ` Manuel Giraud
2022-06-14 9:38 ` Manuel Giraud
2022-06-14 11:35 ` Eli Zaretskii [this message]
2022-06-14 12:34 ` Stefan Monnier
2022-06-14 17:46 ` Eli Zaretskii
2022-06-15 7:59 ` Manuel Giraud
2022-06-18 11:16 ` Eli Zaretskii
2022-06-18 11:29 ` Akib Azmain Turja
2022-06-18 11:33 ` Akib Azmain Turja
2022-06-20 9:58 ` Manuel Giraud
2022-06-20 11:28 ` Eli Zaretskii
2022-06-20 15:28 ` Manuel Giraud
2022-06-20 15:52 ` Eli Zaretskii
2022-06-25 9:35 ` Eli Zaretskii
2022-06-15 12:27 ` Stefan Monnier
2022-06-15 13:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkuvtr3q.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).