From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master bfa951cdfa: Fix invalid current buffer after print-unreadable-function signals Date: Thu, 28 Jul 2022 11:31:15 +0300 Message-ID: <83bkt9abak.fsf@gnu.org> References: <165891496054.3950.2967202128456340980@vcs2.savannah.gnu.org> <20220727094240.C94FEC0F1E3@vcs2.savannah.gnu.org> <87y1weyj6b.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org, luangruo@yahoo.com To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 28 11:01:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGzOD-0003A1-2o for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jul 2022 11:01:05 +0200 Original-Received: from localhost ([::1]:34034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGzOB-0006e0-Q7 for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Jul 2022 05:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyvG-0001Nz-Gp for emacs-devel@gnu.org; Thu, 28 Jul 2022 04:31:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyvF-0000Jn-Mc; Thu, 28 Jul 2022 04:31:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MNZsNDvVSCpw7g6z6wR6MxlPMjd/BRL51G3K7Jno0Qw=; b=RSKdlNjzlsZl jeINFA6y0QSSBeKZscB/czQGn0nIXpFDFxctOgrtzQVuUsuUpvVRZrWgl9Nhoy6KRUbvR59rzGjGu vVegPkp/7T0vfTMePV60P0nSpt5OiaxjpYJNeMGHnboqc6oWcg97RoYARVt6gRY1w7C8rChk+Hdg1 dpfcJFHsnwoTXhueek4IBAOzJ7t36zjW8g45G+apXwlMJ+fgprmPw5wKyWJ+ZXERJ1wiRcQi93nvL ptMAabSWTaFFGVfyh4Cax2xnjEeolkYxjjBE8zgGntFKTHFQnz0brK3zngFYKoPcpWjfRGJ8u+Soo D4mr3bMRxhZsiMz9vBG7EQ==; Original-Received: from [87.69.77.57] (port=4686 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyvC-0001B0-9S; Thu, 28 Jul 2022 04:31:07 -0400 In-Reply-To: (message from Stefan Kangas on Thu, 28 Jul 2022 01:14:30 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292774 Archived-At: > From: Stefan Kangas > Date: Thu, 28 Jul 2022 01:14:30 -0700 > Cc: Po Lu > > Lars Ingebrigtsen writes: > > > Po Lu via Mailing list for Emacs changes writes: > > > >> Fix invalid current buffer after print-unreadable-function signals > >> > >> * src/print.c (PRINTPREPARE): Remove `old' and > >> record_unwind_current_buffer instead. > >> (PRINTFINISH): Stop restoring `old'. (bug#56773) > > > > This apparently leads to: > > > > 1 unexpected results: > > FAILED terpri > > > > in print-tests.el. > > If there is no quick fix, could we please revert the change? > > It's currently stopping me from merging emacs-28 to master. Why does it prevent a merge?