From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master f7b84345f8 1/2: ; * doc/emacs/vc1-xtra.texi (Editing VC Commands): Fix wording. Date: Sat, 01 Oct 2022 08:48:52 +0300 Message-ID: <83bkqwccvv.fsf@gnu.org> References: <166456427452.19714.6372202545661875453@vcs2.savannah.gnu.org> <20220930185754.DF8FAC00615@vcs2.savannah.gnu.org> <877d1k8lxw.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 01 07:49:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeVNf-0002Qk-Gx for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Oct 2022 07:49:43 +0200 Original-Received: from localhost ([::1]:56858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oeVNe-0008N6-AJ for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Oct 2022 01:49:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeVN3-0007gr-5n for emacs-devel@gnu.org; Sat, 01 Oct 2022 01:49:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeVN2-00008t-Om; Sat, 01 Oct 2022 01:49:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qGio2aF8epxZAvM6VvAXMjfAeYWj//uIKdWai0hsWNc=; b=oGJovtf1i76L u5NjhceohE9MlZPjoZw4AruKRoXVDc6n30BPYz6vuH/Wl/ckAxRgBI9IoVPp67g6z/GtvLDF/894q 2jPpwh8doEpkm9uVdcTfLawwRTakbIk1tLXBg2r2ey4ib6bqz/s+F68raEplqwZXUt3sEX3EYLSAc 3Cvfp2CK4lktO6bLvuXo4307ZGV/LiYvOgubyCceOW8lZsIu+5GiF8EkF5WeOz0EZyD4+4ozqtfrc RZ+isCSRdW0k0evPkKSIax5aFNwsWK/UVnn0jMZ1Po4CyZBx8AXkNUZ2Z3UDDYBO24fWtOXCv9LMN pBl7KlwMRKdT+YYCfkizWg==; Original-Received: from [87.69.77.57] (port=1596 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeVN2-00037C-2H; Sat, 01 Oct 2022 01:49:04 -0400 In-Reply-To: <877d1k8lxw.fsf@melete.silentflame.com> (message from Sean Whitton on Fri, 30 Sep 2022 16:46:51 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296541 Archived-At: > From: Sean Whitton > Date: Fri, 30 Sep 2022 16:46:51 -0700 > > Hello Eli, > > Thank you for reviewing the commit. You are welcome. > > --- a/doc/emacs/vc1-xtra.texi > > +++ b/doc/emacs/vc1-xtra.texi > > @@ -270,16 +270,17 @@ with the file's version control type. > > @findex vc-edit-next-command > > @kindex C-x v ! > > You can use the @kbd{C-x v !} (@code{vc-edit-next-command}) prefix > > -command to request an opportunity to edit the VC shell commands that > > -Emacs will run. This is primarily intended to make it possible to > > -access version control system-specific functionality without > > -complexifying either the VC command set or the backend API. > > +command to edit the shell command line that VC is about to run. This > > +is primarily intended to make it possible to add optional command-line > > +arguments to VCS commands without unnecessary complications of the VC > > +command set and its interfaces with the backend. > > I would like to restore the idea that it's about accessing VC > system-specific features, because adding optional command line arguments > is merely the means by which they are accessed. How about: > > This is primarily intended to make it possible to access version > control system-specific functionality, by means of adding optional > command line arguments to VCS commands, without unwanted > complications of the VC command set and its interfaces with the > backend. The original text ("access version control system-specific functionality") was too vague, and I attempted to make it more concrete and clear. I don't understand why that part is so important to have it, especially if you agree that the most frequent expression of "accessing version control system-specific functionality" is to add optional command-line arguments. Isn't it clear to any reader that adding command-line arguments will activate additional functionality?