From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master f7816c94b6: * lisp/outline.el: Pre-compute some frequent
 data for button icons
Date: Sun, 23 Oct 2022 22:27:50 +0300
Message-ID: <83bkq2qr0p.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="18578"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Juri Linkov <juri@linkov.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 24 06:36:16 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1ompCB-0004hU-K4
	for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Oct 2022 06:36:15 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1omnJ5-0005IN-Q0; Sun, 23 Oct 2022 22:35:15 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1omgdi-0001BY-4s
 for emacs-devel@gnu.org; Sun, 23 Oct 2022 15:28:06 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1omgdh-0005uO-Rq; Sun, 23 Oct 2022 15:28:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to:
 references; bh=Nt4WDgOY63vhm0tSZgDgmNFTTYQyMnVIaLgjs5dG9X8=; b=CXsEUZlFwJ6fWv
 cNuSjehP2x8Ca+bO1eJPva/4ZtluEVyt0rQOHoxPdiibyffPAV/6pDB/R3xCJf5kSiGZfdTFCdEqR
 yxI15Ojpsot1Pp/wSM1JksLQHTuiNswoHnnMrXKNqOLTZmkARatcrb5fHHeuqQ8kdORBpscmNlZzi
 apdwNQp6ebD9Kvj2DH58v/DMbhcdWDXYIOQCpYCpH7fRFks7LAfnLqUT5FVbS8+IjSAX8yrXZ++ru
 xy6/gBDQshIM8BTV1pPp2m3JTsW63nLb2bDJJgqiwTwfgznk7xr5Cy/lq9kduqEidf9vT6hePQHiA
 Dg6tzXDIPSI8Wx40vsrQ==;
Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1omgdh-0002vQ-AK; Sun, 23 Oct 2022 15:28:05 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: "Emacs-devel" <emacs-devel-bounces@gnu.org>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:298310
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/298310>

> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1237,7 +1237,7 @@ completions-group-title
>    :version "28.1")
> 
>  (defface completions-group-separator
> -  '((t :inherit shadow :strike-through t))
> +  '((t :inherit shadow :underline t))
>    "Face used for the separator lines between the candidate groups."
>    :version "28.1")

Why is this change a good idea?  That face was introduced in Emacs 28,
so it's already out in the wild.  Why change the default now?  If you
personally don't like the looks, you can change it in your
configuration.

And if we _are_ changing the default, the :version tag should be
adjusted.