From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map'. Date: Mon, 16 Jan 2023 18:58:45 +0200 Message-ID: <83bkmy4dru.fsf@gnu.org> References: <167346587385.21119.11842722402918987249@vcs2.savannah.gnu.org> <20230111193754.33EF3C00A7F@vcs2.savannah.gnu.org> <87fscaeg5s.fsf@gmail.com> <83lem24kia.fsf@gnu.org> <878ri2ed4h.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, juri@linkov.net To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 16 17:59:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHSpF-0001dL-Ca for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Jan 2023 17:59:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHSok-0002yB-U8; Mon, 16 Jan 2023 11:58:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHSog-0002ud-NT for emacs-devel@gnu.org; Mon, 16 Jan 2023 11:58:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHSog-00070M-0O; Mon, 16 Jan 2023 11:58:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=iPOBorex3SJgIDORQIptd617Fh6aquiiJxQ1fVEagrI=; b=nyXwdArG/9QbNfK2kVZr Est+i998AaNC/5NkAmHev5ZL5BWCmZeTDBQcRgGf9B++q5S4Le67t6v89vnv5UTXoFK1y1e7WXnz0 MOJCi1QdYpTRgtSiTS64gW2CvNIpW+3rOzRPd7zJQp0PMRMgqgPIsCVRaUmq7RIv1TiFGczOOfgHy mR04V1KAIPsosCQLUhU9GnAFItFFiNqucQb+Yp1Pt4ddlI4oOWw8ZT2//9nwIswDegnuPFjdt95g0 0uEl77vWzit36waYqShaKG7XRN7tqP3jr4WqOqJRp82YgebgbM9Uh8YhrfGfVCK7JSqQi3h5K//JA oMbMcK97eoEmnA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHSoe-0000s1-Ip; Mon, 16 Jan 2023 11:58:37 -0500 In-Reply-To: <878ri2ed4h.fsf@gmail.com> (message from Robert Pluim on Mon, 16 Jan 2023 16:02:38 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302462 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org, juri@linkov.net > Date: Mon, 16 Jan 2023 16:02:38 +0100 > > >> Juri/Eli, any objection to putting something like the following in > >> emacs-29? That would make it easier to add heading-specific bindings > >> in NEWS mode, which Iʼd do in master. It also avoids creating a > >> separate keymap for each heading. > > Eli> I don't think I understand the problem you are trying to solve, and > Eli> why this particular solution. Please tell more. > > In outline-mode and modes derived from it, there are various bindings > that work at the start of headings (and in buttons that could be > inserted depending on the value of `outline-minor-mode-use-buttonsʼ), > such as "RET" for `outline-cycle'. > > Adding more bindings there is a pain, since the bindings are done > using a separate anonymous keymap on each per-heading overlay, which > means iterating over all the overlays in order to make changes. The > patch I sent changes that to use a named keymap, so only the named > keymap needs to be updated or `setq-local'ʼd before invoking > `outline-mode'. Ah, okay. Fine with me if Juri (or someone else) doesn't object. > (and what I really want to do is add 'n' and 'p' into that map, which > improves the speed at which I can proofread NEWS.) On master or emacs-29?