From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: displaying margins leads to Emacs hanging Date: Sat, 25 Feb 2023 12:51:28 +0200 Message-ID: <83bklikogf.fsf@gnu.org> References: <83edqen95b.fsf@gnu.org> <838rgmn6y4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3105"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: dalanicolai Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 25 11:51:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVs9i-0000fy-Ur for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Feb 2023 11:51:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVs9I-0001Vj-Nk; Sat, 25 Feb 2023 05:51:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVs9H-0001Va-S8 for emacs-devel@gnu.org; Sat, 25 Feb 2023 05:51:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVs9H-0002Fe-K8; Sat, 25 Feb 2023 05:51:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E6+8YLJm3SeRMxWd4JdxGhgJf328oMxYaOw5xLvCXVU=; b=DUkwBHPTAK3S /ONH0hbi6pGuOXfwSgGDIZZWRdpxy42Bb5A372Ph3WdP3j8tlXFVW3xe/aq7Qg5xWPXPy4BeEF3Un yI5CHinrnixe+lw56MAwaCR75RUyiJp6ykC+z8xxwlTma/zMmSVMBSJKE0VAZ1iYKKw87A7v6moTM sLfUNRGF7/AjcRT4wAeLKA9R+/cUZqBfFgC6SwuaBFieMPjvTD8fKfn0ALfDUjsieDgleLISnYMJk oqEkYFmEQM+CzJvJgFj2Hb49R7dmupUAKHWfd1NkPkd/Bv0lyfCt0UxPrW8/RE1DbETzdvtAQ/jCh EfY1td7jo6nSZ0NkJzUKZA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVs9G-00006z-G0; Sat, 25 Feb 2023 05:51:27 -0500 In-Reply-To: (message from dalanicolai on Fri, 24 Feb 2023 21:53:35 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303794 Archived-At: > From: dalanicolai > Date: Fri, 24 Feb 2023 21:53:35 +0100 > Cc: emacs-devel@gnu.org > > B.t.w if someone want to have a look, I'll attach a smaller file here where > I have just removed about 200 pages of the book text data, so that it is > the file is much smaller, but there is still enough date to clearly show the > 'undesired' behavior. > > So now, Emacs will not 'hang', but there will still be a clear difference in time it > takes to update the buffer (between when window margins are displayed, > and when they are not). Your code overwhelms redisplay with an inconceivably huge number of overlays that are left from the previous iteration. This one-line change makes the code work reasonably fast: (defun baleen-update2 () ;; (let ((query (minibuffer-contents))) ;; (with-current-buffer (get-buffer-create "*baleen*") ;; (erase-buffer) ;; (baleen-render (baleen-filter test2 query))))) (let* ((query (minibuffer-contents)) (query-length (length query))) (if (> (length previous-query) query-length) (with-current-buffer (get-buffer-create "*baleen*") (erase-buffer) (baleen-render (cdr (alist-get query baleen-results nil nil #'string=)))) (let* ((parent-results (unless (< query-length 2) (alist-get (substring query 0 -1) baleen-results nil nil #'string=))) (current-results (if parent-results (baleen-filter parent-results query) (unless (string-empty-p query) (baleen-filter test2 query))))) (when current-results (with-current-buffer (get-buffer-create "*baleen*") (remove-overlays) <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< (erase-buffer) (baleen-render current-results)) (cl-pushnew (cons query current-results) baleen-results :test #'string= :key #'car)) (setq previous-query query)))))