unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Mingrone <jrm@ftfl.ca>
Cc: emacs-devel@gnu.org, mattiase@acm.org, emacs@FreeBSD.org
Subject: Re: master 52b67740d10: Generalise a LAP optimisation rule
Date: Mon, 03 Apr 2023 20:45:05 +0300	[thread overview]
Message-ID: <83bkk4vp0e.fsf@gnu.org> (raw)
In-Reply-To: <86ttxw3ltj.fsf@phe.ftfl.ca> (message from Joseph Mingrone on Mon, 03 Apr 2023 14:41:28 -0300)

> From: Joseph Mingrone <jrm@ftfl.ca>
> Cc: Mattias Engdegård <mattiase@acm.org>, emacs@FreeBSD.org
> Date: Mon, 03 Apr 2023 14:41:28 -0300
> 
> On Sat, 2023-03-25 at 12:22, Mattias Engdegård <mattiase@acm.org> wrote:
> 
> > branch: master
> > commit 52b67740d10df8ca539fdc2c7d50283997683141
> > Author: Mattias Engdegård <mattiase@acm.org>
> > Commit: Mattias Engdegård <mattiase@acm.org>
> 
> >     Generalise a LAP optimisation rule
> 
> >     * lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode):
> >     Accept (stack-set 1) as equivalent to (discardN-preserve-tos 1) in a
> >     rule previously overlooked.  This is usually beneficial in code size
> >     and almost always shortens dynamic paths.
> > ---
> >  lisp/emacs-lisp/byte-opt.el | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> > diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
> > index 3c7aeb89525..0891ec80beb 100644
> > --- a/lisp/emacs-lisp/byte-opt.el
> > +++ b/lisp/emacs-lisp/byte-opt.el
> > @@ -2765,7 +2765,9 @@ If FOR-EFFECT is non-nil, the return value is assumed to be of no importance."
> >                        (or (memq (caar tmp) '(byte-discard byte-discardN))
> >                            ;; Make sure we don't hoist a discardN-preserve-tos
> >                            ;; that really should be merged or deleted instead.
> > -                          (and (eq (caar tmp) 'byte-discardN-preserve-tos)
> > +                          (and (or (eq (caar tmp) 'byte-discardN-preserve-tos)
> > +                                   (and (eq (caar tmp) 'byte-stack-set)
> > +                                        (eql (cdar tmp) 1)))
> >                                 (let ((next (cadr tmp)))
> >                                   (not (or (memq (car next)
> >                                                  '(byte-discardN-preserve-tos
> 
> Hello,
> 
> This commit causes native compilation builds on FreeBSD to fail with the error
> 
> 	native-ice ("org/org-plot.el" "block does not end with a branch"...

No, that's bug#62481, which is already solved on emacs-29 and the fix
should be merged to master soon.



  reply	other threads:[~2023-04-03 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167976134206.19776.1825822435181145052@vcs2.savannah.gnu.org>
     [not found] ` <20230325162222.64223C1391B@vcs2.savannah.gnu.org>
2023-04-03 17:41   ` master 52b67740d10: Generalise a LAP optimisation rule Joseph Mingrone
2023-04-03 17:45     ` Eli Zaretskii [this message]
2023-04-04  8:10     ` Andrea Corallo
2023-04-04 16:13       ` Joseph Mingrone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkk4vp0e.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=emacs@FreeBSD.org \
    --cc=jrm@ftfl.ca \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).