From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Updating *Completions* as you type
Date: Sun, 03 Dec 2023 19:56:42 +0200
Message-ID: <83bkb76ug5.fsf@gnu.org>
References: <87bkd3z9bi.fsf@catern.com> <86y1esuajx.fsf@mail.linkov.net>
 <ierleas4fcr.fsf@janestreet.com> <86v89ws5t3.fsf@mail.linkov.net>
 <iercyw445tu.fsf@janestreet.com> <86v89vzf1o.fsf@mail.linkov.net>
 <87pm03jn3w.fsf@catern.com> <861qcjw3ch.fsf@mail.linkov.net>
 <ier1qcin8db.fsf@janestreet.com> <86r0ki2on3.fsf@mail.linkov.net>
 <ierttpdlqe4.fsf@janestreet.com> <86leao519y.fsf@mail.linkov.net>
 <87fs0wk5oq.fsf@catern.com> <86edgfin4v.fsf@mail.linkov.net>
 <87o7fhixzv.fsf@catern.com> <86o7fhy9ae.fsf@mail.linkov.net>
 <87v89ohc6f.fsf@catern.com> <86il5nhdvh.fsf@mail.linkov.net>
 <87plzuuend.fsf@catern.com> <837cm19ay3.fsf@gnu.org>
 <877cm1v3ez.fsf@catern.com> <86leab8agz.fsf@mail.linkov.net>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="22185"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: sbaugh@catern.com, sbaugh@janestreet.com, emacs-devel@gnu.org
To: Juri Linkov <juri@linkov.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 03 18:57:28 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1r9qid-0005WX-Tn
	for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Dec 2023 18:57:28 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1r9qhw-0004Fr-6W; Sun, 03 Dec 2023 12:56:44 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1r9qhv-0004Fj-AJ
 for emacs-devel@gnu.org; Sun, 03 Dec 2023 12:56:43 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1r9qht-0007wC-BT; Sun, 03 Dec 2023 12:56:41 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=pyV+blQpxBzVUMn5ufUWU2gM9uQVe4dFIyDyrLLvgso=; b=heottOu+qcU4
 XGeMruKy8wtlMbMlLi91g9+YLEHARWBE6Hh88Gl6Fx2zSYH91yq54aNAMJkmFy5ClxeAGItUYb4l4
 lDmxFUCpGnsb3a1xr2j0CzwIO3zZqmCzYaeaHTZTG+NOTBpf6LF7sNteqEaK5LqypNtSDFa3tpjdN
 t9o6fJ+p9352sd5rQ9+tpbcxJ9U2PisYLQ67V6dxsi7+jHlPhqqqhw2pmiDHOwkHupxRavP+T/RLt
 LFrP94q2BX5k3pjmu0rgtAXdaOittRSvfvpzu2DebUqUZLKq9ARDvyJ1lbHW/MKNX+UIeNzzC1TFt
 G/LjPkM3eG9D7q9h7CAH7w==;
In-Reply-To: <86leab8agz.fsf@mail.linkov.net> (message from Juri Linkov on
 Sun, 03 Dec 2023 19:25:16 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:313495
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/313495>

> From: Juri Linkov <juri@linkov.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, sbaugh@janestreet.com, emacs-devel@gnu.org
> Date: Sun, 03 Dec 2023 19:25:16 +0200
> 
> > Fixed patch for everything else:
> 
> No more comments in three days, so your latest patch is pushed now, thanks.

The NEWS entry says:

  *** New value 'historical' for user option 'completions-sort'
  When 'completions-sort' is set to 'historical', completion candidates
  will be sorted by their chronological order in the minibuffer history,
  with more recent candidates appearing first.

But if "more recent candidates appear first", this is not the
chronological order, this is the reverse chronological order.  So
which part of the above is correct, the "chronological order" part or
the "more recent candidates first" part?

Btw, the doc string of minibuffer-sort-by-history seems to indicate
that both the above NEWS entry and the doc string of the user options
omit crucial details:

  COMPLETIONS are sorted first by `minibuffer-sort-alphbetically',
  then any elements occuring in the minibuffer history list are
  moved to the front based on the chronological order they occur in
  the history.

This "alphabetical order first" part is not mentioned anywhere else.
It should at least be mentioned in the doc string of the user option
and at least hinted upon in NEWS.