unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* record_unwind_save_match_data in autocmp_chars
@ 2009-10-03  9:43 Eli Zaretskii
  2009-10-05  0:42 ` Kenichi Handa
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2009-10-03  9:43 UTC (permalink / raw)
  To: Kenichi Handa; +Cc: emacs-devel

composite.c:autocmp_chars calls record_unwind_save_match_data before
it starts looping on an element of composition-function-table.
However, since the loop calls fast_looking_at, which is documented not
to change match data, is the call to record_unwind_save_match_data
really necessary?  If it is still necessary, what other functions
called by autocmp_chars might clobber match data?




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: record_unwind_save_match_data in autocmp_chars
  2009-10-03  9:43 record_unwind_save_match_data in autocmp_chars Eli Zaretskii
@ 2009-10-05  0:42 ` Kenichi Handa
  0 siblings, 0 replies; 2+ messages in thread
From: Kenichi Handa @ 2009-10-05  0:42 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

In article <83ab08q0bq.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> composite.c:autocmp_chars calls record_unwind_save_match_data before
> it starts looping on an element of composition-function-table.
> However, since the loop calls fast_looking_at, which is documented not
> to change match data, is the call to record_unwind_save_match_data
> really necessary?  If it is still necessary, what other functions
> called by autocmp_chars might clobber match data?

autocmp_chars calls the Lisp function auto-compose-chars via
safe_call, and auto-compose-chars calls Lisp functions
registered in composition-function-table.

---
Kenichi Handa
handa@m17n.org




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-05  0:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-03  9:43 record_unwind_save_match_data in autocmp_chars Eli Zaretskii
2009-10-05  0:42 ` Kenichi Handa

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).