From: Eli Zaretskii <eliz@gnu.org>
To: Kenichi Handa <handa@m17n.org>, Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: AUTO_COMPOSED_PROP_IDX unused?
Date: Tue, 01 Dec 2009 06:14:49 +0200 [thread overview]
Message-ID: <83aay3miti.fsf@gnu.org> (raw)
In-Reply-To: <tl77ht8ak7l.fsf@m17n.org>
> From: Kenichi Handa <handa@m17n.org>
> Cc: emacs-devel@gnu.org
> Date: Mon, 30 Nov 2009 10:13:18 +0900
>
> In article <83hbsemx26.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
>
> > In dispextern.h we have:
> > enum prop_idx
> > {
> > AUTO_COMPOSED_PROP_IDX,
> [...]
>
> > However, no one seems to use AUTO_COMPOSED_PROP_IDX. It looks like a
> > left-over from the previous implementation of automatic compositions,
> > which used text properties.
>
> Right. The current Emacs never put `auto-composed' property now.
>
> > OK to delete AUTO_COMPOSED_PROP_IDX from the enumeration?
>
> I think so.
>
> In article <87skbyii7j.fsf@stupidchicken.com>, Chong Yidong <cyd@stupidchicken.com> writes:
>
> > I'm not sure it's safe. If you want to do it, please wait till after
> > the 23.2 release.
>
> If deleting it causes a problem, it means that we have some
> bug that is currently hidden but will be revealed by unknown
> condition. It is better to find out such a bug if any.
Yidong, do you still want to wait with this until after v23.2, or can
I go ahead and delete AUTO_COMPOSED_PROP_IDX?
next prev parent reply other threads:[~2009-12-01 4:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 16:30 AUTO_COMPOSED_PROP_IDX unused? Eli Zaretskii
2009-11-28 19:04 ` Chong Yidong
2009-11-28 19:28 ` Eli Zaretskii
2009-11-30 1:13 ` Kenichi Handa
2009-12-01 4:14 ` Eli Zaretskii [this message]
2009-12-01 15:55 ` Chong Yidong
2009-12-01 18:44 ` Eli Zaretskii
2009-12-01 21:47 ` Stefan Monnier
2009-12-04 10:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83aay3miti.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).