From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bidi properties from uniprop tables Date: Fri, 19 Aug 2011 09:43:51 +0300 Message-ID: <83aab5sxy0.fsf@gnu.org> References: <83ei0isfok.fsf@gnu.org> <87k4aako1r.fsf@uwakimon.sk.tsukuba.ac.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1313736240 20360 80.91.229.12 (19 Aug 2011 06:44:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 19 Aug 2011 06:44:00 +0000 (UTC) Cc: emacs-devel@gnu.org, handa@m17n.org To: "Stephen J. Turnbull" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 19 08:43:56 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QuIo7-0005Bg-I4 for ged-emacs-devel@m.gmane.org; Fri, 19 Aug 2011 08:43:55 +0200 Original-Received: from localhost ([::1]:38066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuIo6-0002mw-TS for ged-emacs-devel@m.gmane.org; Fri, 19 Aug 2011 02:43:54 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuIo4-0002kL-Ig for emacs-devel@gnu.org; Fri, 19 Aug 2011 02:43:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QuIo2-00039W-HU for emacs-devel@gnu.org; Fri, 19 Aug 2011 02:43:52 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:46004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QuIo2-00039M-B9 for emacs-devel@gnu.org; Fri, 19 Aug 2011 02:43:50 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LQ500J00XBE1800@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Fri, 19 Aug 2011 09:43:48 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.124.178.145]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LQ5002NKXCZTK26@a-mtaout20.012.net.il>; Fri, 19 Aug 2011 09:43:48 +0300 (IDT) In-reply-to: <87k4aako1r.fsf@uwakimon.sk.tsukuba.ac.jp> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:143422 Archived-At: > From: "Stephen J. Turnbull" > Cc: Kenichi Handa , > emacs-devel@gnu.org > Date: Fri, 19 Aug 2011 13:44:48 +0900 > > > I made the code in bidi.c defensive about what it gets from the > > Maybe that should be an assert, since a null return is an Emacs bug. There's already something that catches such problems, albeit indirectly, and aborts -- that's how I found this in the first place. However, it doesn't make sense to have an assert where the bidi property of a character is looked up as long as we don't make sure this doesn't happen "normally", because having such an assert now will cause a predictable crash when moving in a buffer created by describe-categories. People use the development version for their day-to-day work, you know... > > uniprop table, but the question is, should we do something to never > > have nil in Lisp or zero in C return from these APIs? > > Yes, a non-nil property list is required by the standard for all code > points It's not a property list, it's a single property whose value is a symbol that shouldn't be nil. See get-char-code-property.