From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/4] Refactor window-system configuration Date: Fri, 30 Dec 2011 10:19:05 +0200 Message-ID: <83aa6av5dy.fsf@gnu.org> References: <4b98eec4a5f68bfcd9233d5e7444de05873225b4.1325166472.git.dancol@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1325233158 29615 80.91.229.12 (30 Dec 2011 08:19:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2011 08:19:18 +0000 (UTC) Cc: dancol@dancol.org, emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 30 09:19:14 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgXgI-0006YQ-3Z for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2011 09:19:14 +0100 Original-Received: from localhost ([::1]:34244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgXgH-0004uv-Kl for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2011 03:19:13 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:59649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgXgF-0004uf-6P for emacs-devel@gnu.org; Fri, 30 Dec 2011 03:19:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgXgE-00037N-4D for emacs-devel@gnu.org; Fri, 30 Dec 2011 03:19:11 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:51464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgXgC-000377-1r; Fri, 30 Dec 2011 03:19:08 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LX000400C334R00@a-mtaout20.012.net.il>; Fri, 30 Dec 2011 10:19:06 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.18.76]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LX00029ZCFSIH01@a-mtaout20.012.net.il>; Fri, 30 Dec 2011 10:19:06 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147030 Archived-At: > From: Dan Nicolaescu > Date: Thu, 29 Dec 2011 17:21:09 -0500 > Cc: emacs-devel@gnu.org > > We don't use something like "#include TERM_HEADER" in any other place Well, technically we do. We have this in config.h: #include config_opsysfile #ifdef config_machfile # include config_machfile #endif But I agree with Dan that this technique should be avoided, as it adds to complexity. Daniel, can you describe the difficulties in using a string rather than a macro for doing what you want?