unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: Another ptrdiff_t
Date: Sun, 22 Jul 2012 18:43:11 +0300	[thread overview]
Message-ID: <83a9yr244w.fsf@gnu.org> (raw)

Another ptrdiff_t enters the scene.

Can we perhaps have some conventions regarding which integer types to
use in what situations?


=== modified file 'src/ChangeLog'
--- src/ChangeLog	2012-07-21 19:26:25 +0000
+++ src/ChangeLog	2012-07-22 03:44:35 +0000
@@ -1,3 +1,8 @@
+2012-07-22  Paul Eggert  <eggert@cs.ucla.edu>
+
+	* buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
+	as it's limited by the amount of memory, not by INT_MAX.
+
 2012-07-21  Eli Zaretskii  <eliz@gnu.org>
 
 	* keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'

=== modified file 'src/buffer.h'
--- src/buffer.h	2012-07-20 16:05:47 +0000
+++ src/buffer.h	2012-07-22 03:44:35 +0000
@@ -776,9 +776,9 @@ struct buffer
   struct buffer *base_buffer;
 
   /* In an indirect buffer, this is -1. In an ordinary buffer,
-     it's the number of indirect buffers which shares our text;
+     it's the number of indirect buffers that share our text;
      zero means that we're the only owner of this text.  */
-  int indirections;
+  ptrdiff_t indirections;
 
   /* A non-zero value in slot IDX means that per-buffer variable
      with index IDX has a local value in this buffer.  The index IDX




             reply	other threads:[~2012-07-22 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22 15:43 Eli Zaretskii [this message]
2012-07-23  8:59 ` Another ptrdiff_t Stefan Monnier
2012-07-23 21:41 ` Paul Eggert
2012-07-24 12:23   ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a9yr244w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).