From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change. Date: Fri, 03 Mar 2017 10:11:03 +0200 Message-ID: <83a892n5k8.fsf@gnu.org> References: <83y3wqnvol.fsf@gnu.org> <83tw7enq58.fsf@gnu.org> <83r32inna5.fsf@gnu.org> <83bmtlnd4l.fsf@gnu.org> <83mvd3mzus.fsf@gnu.org> <83fuivmnz3.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1488528696 22704 195.159.176.226 (3 Mar 2017 08:11:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Mar 2017 08:11:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 03 09:11:32 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjiJD-00053t-Cs for ged-emacs-devel@m.gmane.org; Fri, 03 Mar 2017 09:11:27 +0100 Original-Received: from localhost ([::1]:56656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjiJJ-000804-Dy for ged-emacs-devel@m.gmane.org; Fri, 03 Mar 2017 03:11:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjiJ9-0007yg-UF for emacs-devel@gnu.org; Fri, 03 Mar 2017 03:11:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjiJ6-0005ON-Pq for emacs-devel@gnu.org; Fri, 03 Mar 2017 03:11:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjiJ6-0005OJ-Mr; Fri, 03 Mar 2017 03:11:20 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2485 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cjiJ5-0000hx-JE; Fri, 03 Mar 2017 03:11:20 -0500 In-reply-to: (message from Stefan Monnier on Thu, 02 Mar 2017 17:32:52 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212731 Archived-At: > From: Stefan Monnier > Date: Thu, 02 Mar 2017 17:32:52 -0500 > > >> > Isn't it easier to keep the record of changes in these variables in > >> > the buffer object, like we do with BUF_MODIFF etc.? > >> I don't understand the question. Which "these variables" are you > >> talking about? > > The 3 variables related to overlay-arrow whose changes need to trigger > > redisplay of the respective buffers: overlay-arrow-position, > > overlay-arrow-string, and overlay-arrow-bitmap. > > But that means we need to watch variable assignments, marker > modifications, and symbol property modifications. Using overlays gets > us all this "for free" because we already watch all overlay modifications. Variables and markers, yes. Symbol properties: I don't see why would we need to watch them. Anyway, it was just a thought. It sounds like a conceptually simpler, even if the implementation is somewhat hairy.