From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fix for org-mode fontification (Bug#25132) fix on emacs-25? Date: Tue, 21 Mar 2017 05:30:22 +0200 Message-ID: <83a88fwbld.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1490067083 9103 195.159.176.226 (21 Mar 2017 03:31:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 21 Mar 2017 03:31:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 21 04:31:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqAVx-0001jB-4g for ged-emacs-devel@m.gmane.org; Tue, 21 Mar 2017 04:31:17 +0100 Original-Received: from localhost ([::1]:36475 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqAW2-00047D-Ti for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2017 23:31:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqAVK-0003mr-CU for emacs-devel@gnu.org; Mon, 20 Mar 2017 23:30:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqAVH-0007eT-AG for emacs-devel@gnu.org; Mon, 20 Mar 2017 23:30:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqAVH-0007eB-7M; Mon, 20 Mar 2017 23:30:35 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cqAVG-0006x5-Gp; Mon, 20 Mar 2017 23:30:34 -0400 In-reply-to: (message from Noam Postavsky on Mon, 20 Mar 2017 22:11:45 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213193 Archived-At: > From: Noam Postavsky > Date: Mon, 20 Mar 2017 22:11:45 -0400 > > I goofed when pushing the fix for Bug#25132, for some reason I decided > to extend let-binding wider than my initial patch. This causes a > fontification error when combined with some other (undetermined, but > Spacemacs was mentioned) packages [1]. > > Fixed with the diff below (ignoring whitespace changes for > readability) which narrows the scope of the let-binding (the > let-binding was introduced for 25.2 to fix #25132). Should this go to > emacs-25? Yes, emacs-25 is fine for this. Thanks.