From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: movemail location Date: Sun, 10 Jun 2018 17:59:47 +0300 Message-ID: <83a7s2sn4s.fsf@gnu.org> References: <867en7j3k5.fsf@phe.ftfl.ca> <83lgbnsw9k.fsf@gnu.org> <86vaarzst1.fsf@phe.ftfl.ca> <83efhfsqyw.fsf@gnu.org> <86r2lfzr3o.fsf@phe.ftfl.ca> <83d0wzs77c.fsf@gnu.org> <867en7z7ea.fsf@phe.ftfl.ca> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1528642727 6456 195.159.176.226 (10 Jun 2018 14:58:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2018 14:58:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Joseph Mingrone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 10 16:58:43 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS1nm-0001Yz-Cv for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2018 16:58:42 +0200 Original-Received: from localhost ([::1]:44348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS1pt-0005oD-HB for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2018 11:00:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS1oq-0005mN-Bk for emacs-devel@gnu.org; Sun, 10 Jun 2018 10:59:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS1ol-0002kh-Gs for emacs-devel@gnu.org; Sun, 10 Jun 2018 10:59:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS1ol-0002kb-CY; Sun, 10 Jun 2018 10:59:43 -0400 Original-Received: from [176.228.60.248] (port=4376 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fS1ok-0008Tt-C0; Sun, 10 Jun 2018 10:59:42 -0400 In-reply-to: <867en7z7ea.fsf@phe.ftfl.ca> (message from Joseph Mingrone on Sat, 09 Jun 2018 23:45:33 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226166 Archived-At: > From: Joseph Mingrone > Cc: emacs-devel@gnu.org > Date: Sat, 09 Jun 2018 23:45:33 -0300 > > >> Robert's suggestion [1] sounds reasonable. > > >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31737#15 > > > And mine doesn't? If so, could you say why? > > Let's make sure we are on the same page. > > This is what Robert suggested. > > "Perhaps gnus should check in 'exec-directory' first if > mail-source-movemail-program is nil, and then fall back to > 'executable-find'? Or perhaps we should just forget about 'our' movemail > and require people to install Mailutils. > > I think you are suggesting that Gnus simply specify the executable name, > movemail, and PATH will take care of finding it. Is that correct? > Assuming that works, that also seems reasonable. The only possible > drawback could be for users who specify a value for > `mail-source-movemail-program'. Won't that value be ignored? Sorry, I should have been more explicit. My suggestion is to replace this: (apply 'call-process (append (list (or mail-source-movemail-program (expand-file-name "movemail" exec-directory)) nil errors nil from to))))) with this: (apply 'call-process (append (list (or mail-source-movemail-program "movemail") nil errors nil from to))))) Since call-process calls the moral equivalent of executable-find internally, calling executable-find during initialization is redundant: call-process will find movemail on exec-path; moreover, Robert's suggestion will not work if movemail was installed or moved after mail-source.el was loaded. Did I succeed to explain myself this time?