From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [imenu.el] Attempt to fix broken imenu--generic-function Date: Wed, 18 Jul 2018 05:38:02 +0300 Message-ID: <83a7qp6zg5.fsf@gnu.org> References: <5bda37af-3edd-4938-8ba4-ad6e04032e69@default> <03bf24b4-7040-451d-9a98-e02315b33f91@default> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1531881390 4669 195.159.176.226 (18 Jul 2018 02:36:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2018 02:36:30 +0000 (UTC) Cc: fgunbin@fastmail.fm, emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 18 04:36:26 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffcKG-00016I-Nb for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2018 04:36:24 +0200 Original-Received: from localhost ([::1]:34367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffcMN-0003N6-AE for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 22:38:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffcLi-0003N1-QE for emacs-devel@gnu.org; Tue, 17 Jul 2018 22:37:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffcLf-0004eP-NO for emacs-devel@gnu.org; Tue, 17 Jul 2018 22:37:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffcLf-0004eB-Jy; Tue, 17 Jul 2018 22:37:51 -0400 Original-Received: from [176.228.60.248] (port=1929 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ffcLf-0006KJ-1y; Tue, 17 Jul 2018 22:37:51 -0400 In-reply-to: <03bf24b4-7040-451d-9a98-e02315b33f91@default> (message from Drew Adams on Tue, 17 Jul 2018 16:18:29 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227527 Archived-At: > Date: Tue, 17 Jul 2018 16:18:29 -0700 (PDT) > From: Drew Adams > Cc: emacs-devel@gnu.org > > > > Is this about some Emacs bug? If so, what bug #? > > > Can you please specify what was broken, how/why, etc.? > > > I didn't commit it, but yes, it's for bug #32024. (Shouldn't > the commit log say that?) It does, doesn't it? commit 77166e0da2d58f2f6436989b7059d913be5b3439 Author: Drew Adams Date: Sat Jul 7 19:20:45 2018 +0300 Fix 2 minor bugs in 'imenu--generic-function' * lisp/imenu.el (imenu--generic-function): Move point to START before checking whether the current item is inside a comment or a string. Remove any empty menus that could have been added before returning. (Bug#32024) ^^^^^^^^^