unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: fgunbin@fastmail.fm, emacs-devel@gnu.org
Subject: Re: [imenu.el] Attempt to fix broken imenu--generic-function
Date: Wed, 18 Jul 2018 05:38:02 +0300	[thread overview]
Message-ID: <83a7qp6zg5.fsf@gnu.org> (raw)
In-Reply-To: <03bf24b4-7040-451d-9a98-e02315b33f91@default> (message from Drew Adams on Tue, 17 Jul 2018 16:18:29 -0700 (PDT))

> Date: Tue, 17 Jul 2018 16:18:29 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: emacs-devel@gnu.org
> 
> > > Is this about some Emacs bug?  If so, what bug #?
> > > Can you please specify what was broken, how/why, etc.?
> > 
> I didn't commit it, but yes, it's for bug #32024.  (Shouldn't
> the commit log say that?)

It does, doesn't it?

  commit 77166e0da2d58f2f6436989b7059d913be5b3439
  Author: Drew Adams <drew.adams@oracle.com>
  Date:   Sat Jul 7 19:20:45 2018 +0300

      Fix 2 minor bugs in 'imenu--generic-function'

      * lisp/imenu.el (imenu--generic-function): Move point to START
      before checking whether the current item is inside a comment
      or a string.  Remove any empty menus that could have been
      added before returning.  (Bug#32024)
				^^^^^^^^^



  reply	other threads:[~2018-07-18  2:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 20:34 [imenu.el] Attempt to fix broken imenu--generic-function Filipp Gunbin
2018-07-17 20:55 ` Drew Adams
2018-07-17 22:14   ` Filipp Gunbin
2018-07-17 23:18     ` Drew Adams
2018-07-18  2:38       ` Eli Zaretskii [this message]
2018-07-18 13:12       ` Filipp Gunbin
     [not found]     ` <<03bf24b4-7040-451d-9a98-e02315b33f91@default>
     [not found]       ` <<83a7qp6zg5.fsf@gnu.org>
2018-07-18  4:36         ` Drew Adams
2018-07-18  5:01           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a7qp6zg5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=fgunbin@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).