From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Fri, 03 Aug 2018 09:23:14 +0300 Message-ID: <83a7q4ufxp.fsf@gnu.org> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533277314 29721 195.159.176.226 (3 Aug 2018 06:21:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 06:21:54 +0000 (UTC) Cc: Paul Eggert , Tom Tromey , emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 03 08:21:50 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flTTA-0007cJ-WE for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 08:21:49 +0200 Original-Received: from localhost ([::1]:49139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flTVH-0002DC-Ke for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 02:23:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flTV9-0002C3-2A for emacs-devel@gnu.org; Fri, 03 Aug 2018 02:23:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flTV3-0000td-QX for emacs-devel@gnu.org; Fri, 03 Aug 2018 02:23:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flTUj-0000XS-IA; Fri, 03 Aug 2018 02:23:25 -0400 Original-Received: from [176.228.60.248] (port=1519 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1flTUi-0006h3-VU; Fri, 03 Aug 2018 02:23:25 -0400 In-reply-to: <861sbgz3dm.fsf@gmail.com> (message from Andy Moreton on Fri, 03 Aug 2018 01:43:17 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228115 Archived-At: > From: Andy Moreton > Date: Fri, 03 Aug 2018 01:43:17 +0100 > > After a lot more testing, I have a somewhat scruffy patch that works in > the following emacs builds on unpatched master, and on patched bignum branch: > - cygwin 64bit (LP64 model) > - mingw64 msys2 32bit > - mingw64 msys2 64bit (LLP64 model) I believe your changes also cover the 32-bit MinGW build with wide ints. > The patch contains changes for: > - fix CCL to ensure it uses 28biut codewords properly in bignum build > - ensure make_number creates fixnums in LLP64 builds > - fix bugnumcompare for LLP64 builds > - fix arith_driver to handle markers correctly > - fix arith_driver operations for LLP64 builds (more testing needed) > - fix float_arith_driver to allow bignums > - fix ash_lsh_impl to produce correct results in bignum build > - fix NUMBERP to remove redundant BIGNUMP test (ensured by INTEGERP) Can you tell what is the following hunk about? > @@ -3414,7 +3473,7 @@ Markers are converted to integers. */) > else > { > eassume (FIXNUMP (number)); > - if (XINT (number) > MOST_POSITIVE_FIXNUM) > + if (XINT (number) > MOST_NEGATIVE_FIXNUM) > XSETINT (number, XINT (number) - 1); > else > { Also, this: > +(defun ccl-fixnum (code) > + "Convert a CCL code word to a fixnum value." > + (- (logxor (logand code #x0fffffff) #x08000000) #x08000000)) should have a comment explaining why this function is needed. Btw, isn't it confusing that INTEGERP allows fixnums and bignums, but XINT, XFASTINT, and XSETINT work only with fixnums? I envision quite a few of potential bugs due to this semantic discrepancy, like the one you just fixed: > - fix NUMBERP to remove redundant BIGNUMP test (ensured by INTEGERP) Should we have a different name for what is now INTEGERP? Like WHOLENUMP, for example? Thanks again for working on this.