From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master b01a429: js--re-search-backward-inner: Fix
	infloop
Date: Fri, 01 Feb 2019 09:28:58 +0200
Message-ID: <83a7jgynk5.fsf@gnu.org>
References: <20190201000223.22803.66102@vcs0.savannah.gnu.org>
	<20190201000224.6638E20B45@vcs0.savannah.gnu.org>
	<6f4122fb-8dcc-836d-9b80-388d417f8cc2@yandex.ru>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="6580"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Dmitry Gutov <dgutov@yandex.ru>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 01 08:29:11 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gpTGB-0001aR-Fw
	for ged-emacs-devel@m.gmane.org; Fri, 01 Feb 2019 08:29:11 +0100
Original-Received: from localhost ([127.0.0.1]:40126 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gpTGA-0003io-EA
	for ged-emacs-devel@m.gmane.org; Fri, 01 Feb 2019 02:29:10 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:33529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gpTG1-0003hY-SI
	for emacs-devel@gnu.org; Fri, 01 Feb 2019 02:29:02 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53904)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1gpTG1-0007BU-J0; Fri, 01 Feb 2019 02:29:01 -0500
Original-Received: from [176.228.60.248] (port=3447 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1gpTG1-0000wa-6X; Fri, 01 Feb 2019 02:29:01 -0500
In-reply-to: <6f4122fb-8dcc-836d-9b80-388d417f8cc2@yandex.ru> (message from
	Dmitry Gutov on Fri, 1 Feb 2019 03:27:20 +0300)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:232879
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/232879>

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 1 Feb 2019 03:27:20 +0300
> 
> Any chance I may backport this to emacs-26?

When was this issue introduced?

> The bug was reported only recently, but it seems pretty annoying 
> (infloop during indentation), and the fix is simple.

Taken at face value, it doesn't look simple: you are switching from
using 2 elements of what syntax-ppss returns to a 3rd one.  How do we
know this won't introduce other issues?  Maybe if you describe the
logic of the change, I will agree with you.

Thanks.