unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master b01a429: js--re-search-backward-inner: Fix infloop
Date: Fri, 01 Feb 2019 09:28:58 +0200	[thread overview]
Message-ID: <83a7jgynk5.fsf@gnu.org> (raw)
In-Reply-To: <6f4122fb-8dcc-836d-9b80-388d417f8cc2@yandex.ru> (message from Dmitry Gutov on Fri, 1 Feb 2019 03:27:20 +0300)

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 1 Feb 2019 03:27:20 +0300
> 
> Any chance I may backport this to emacs-26?

When was this issue introduced?

> The bug was reported only recently, but it seems pretty annoying 
> (infloop during indentation), and the fix is simple.

Taken at face value, it doesn't look simple: you are switching from
using 2 elements of what syntax-ppss returns to a 3rd one.  How do we
know this won't introduce other issues?  Maybe if you describe the
logic of the change, I will agree with you.

Thanks.



  reply	other threads:[~2019-02-01  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190201000223.22803.66102@vcs0.savannah.gnu.org>
     [not found] ` <20190201000224.6638E20B45@vcs0.savannah.gnu.org>
2019-02-01  0:27   ` [Emacs-diffs] master b01a429: js--re-search-backward-inner: Fix infloop Dmitry Gutov
2019-02-01  7:28     ` Eli Zaretskii [this message]
2019-02-02  0:08       ` Dmitry Gutov
2019-02-02  7:31         ` Eli Zaretskii
2019-02-23 23:43           ` Dmitry Gutov
2019-02-24  3:36             ` Eli Zaretskii
2019-02-26  1:01               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a7jgynk5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).