unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] * doc/misc/eshell.texi (Built-ins): Fix alias description
@ 2019-02-13 20:01 Gregor Zattler
  2019-02-13 23:51 ` John Wiegley
  0 siblings, 1 reply; 3+ messages in thread
From: Gregor Zattler @ 2019-02-13 20:01 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Dear eamcs developers, eshells current documentation first states
that alias definitions are not saved to an alias file, later that
they are saved to an alias file.  I tested it and the latter is
correct.

Please find attached a patch which fixes this.

Thanks for working on emacs which is really great, Gregor

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-doc-misc-eshell.texi-Built-ins-Fix-alias-description.patch --]
[-- Type: text/x-diff, Size: 820 bytes --]

>From 1fe51cc769ab7a30d0896fb3d6105c0561243fa7 Mon Sep 17 00:00:00 2001
From: Gregor Zattler <telegraph@gmx.net>
Date: Wed, 13 Feb 2019 20:19:38 +0100
Subject: * doc/misc/eshell.texi (Built-ins): Fix alias description.

Bring description of built-in 'alias' in line with (info "(eshell) Aliases"),
which describes the actual behaviur.
---
 doc/misc/eshell.texi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi
index dcb4aac2d8..3540707318 100644
--- a/doc/misc/eshell.texi
+++ b/doc/misc/eshell.texi
@@ -280,8 +280,7 @@ Built-ins
 
 @item alias
 @cmindex alias
-Define an alias (@pxref{Aliases}).  This does not add it to the aliases
-file.
+Define an alias (@pxref{Aliases}).  This adds it to the aliases file.
 
 @item clear
 @cmindex clear
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] * doc/misc/eshell.texi (Built-ins): Fix alias description
  2019-02-13 20:01 [PATCH] * doc/misc/eshell.texi (Built-ins): Fix alias description Gregor Zattler
@ 2019-02-13 23:51 ` John Wiegley
  2019-02-15  7:45   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: John Wiegley @ 2019-02-13 23:51 UTC (permalink / raw)
  To: emacs-devel

>>>>> "GZ" == Gregor Zattler <telegraph@gmx.net> writes:

GZ> Dear eamcs developers, eshells current documentation first states that
GZ> alias definitions are not saved to an alias file, later that they are
GZ> saved to an alias file. I tested it and the latter is correct.

GZ> Please find attached a patch which fixes this.

Pushed, thank you!

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] * doc/misc/eshell.texi (Built-ins): Fix alias description
  2019-02-13 23:51 ` John Wiegley
@ 2019-02-15  7:45   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2019-02-15  7:45 UTC (permalink / raw)
  To: John Wiegley; +Cc: emacs-devel

> From: "John Wiegley" <johnw@gnu.org>
> Date: Wed, 13 Feb 2019 15:51:10 -0800
> 
> >>>>> "GZ" == Gregor Zattler <telegraph@gmx.net> writes:
> 
> GZ> Dear eamcs developers, eshells current documentation first states that
> GZ> alias definitions are not saved to an alias file, later that they are
> GZ> saved to an alias file. I tested it and the latter is correct.
> 
> GZ> Please find attached a patch which fixes this.
> 
> Pushed, thank you!

Thanks, but please push documentation changes to the release branch (I
cherry-picked this one).



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-15  7:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-13 20:01 [PATCH] * doc/misc/eshell.texi (Built-ins): Fix alias description Gregor Zattler
2019-02-13 23:51 ` John Wiegley
2019-02-15  7:45   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).