From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFE] Migration to gitlab Date: Wed, 20 Mar 2019 08:13:11 +0200 Message-ID: <83a7hqt6o8.fsf@gnu.org> References: <1552789070.5272.1@yandex.ru> <1552791707.5272.2@yandex.ru> <1552793646.5272.3@yandex.ru> <1552821396.21432.0@yandex.ru> <83imwhwf4x.fsf@gnu.org> <837ecvux2q.fsf@gnu.org> <9c7cf558-a2d3-951e-d6e1-31b3ad5900cf@yandex.ru> <1553032781.15837.0@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92998"; mail-complaints-to="usenet@blaine.gmane.org" Cc: theophilusx@gmail.com, emacs-devel@gnu.org, dgutov@yandex.ru To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 20 07:14:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6UV5-000NzA-4b for ged-emacs-devel@m.gmane.org; Wed, 20 Mar 2019 07:14:55 +0100 Original-Received: from localhost ([127.0.0.1]:43467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6UV4-0002jr-1M for ged-emacs-devel@m.gmane.org; Wed, 20 Mar 2019 02:14:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6UTW-0001nE-G8 for emacs-devel@gnu.org; Wed, 20 Mar 2019 02:13:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h6UTV-0001MX-S6; Wed, 20 Mar 2019 02:13:18 -0400 Original-Received: from [176.228.60.248] (port=3288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h6UTV-0004CV-6f; Wed, 20 Mar 2019 02:13:17 -0400 In-reply-to: <1553032781.15837.0@yandex.ru> (message from Konstantin Kharlamov on Wed, 20 Mar 2019 00:59:41 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234394 Archived-At: > Date: Wed, 20 Mar 2019 00:59:41 +0300 > From: Konstantin Kharlamov > Cc: Dmitry Gutov , theophilusx@gmail.com, > emacs-devel@gnu.org > > > It is all too easy to disable/bypass the hooks, as you probably know > > very well. So this doesn't sound like an important issue to me. > > It looks too easy when you already know how it works. An aribtrary > newcomer don't. I seriously doubt that. I just now typed into a browser search window "git bypass commit hooks" and the first hit was exactly what I wanted: https://stackoverflow.com/questions/7230820/skip-git-commit-hooks You will have this as the first hit if you do this from Emacs as well: M-s M-w git bypass commit hooks RET > When a newbie wants to change a code, they don't need to know all > contribution details, because they're in hacking stage. They don't need to know, the commit hook will tell them. And bypassing commit hooks is not an Emacs thing, it's a Git thing. > Btw, Emacs already has at least one git hook, and it's so annoying! You can disable the hooks locally if you want. > My point is: moving these destructive checks to the moment of the > actual contribution to upstream (i.e. the gitlab CI that runs for every > merge-request) would make more pleasant experience for contributors, > whilst not taking anything from maintainers (sure, "fix unit-test > failures that your commit caused" is something that a contributor could > probably figure out themselves). And my point is that we are once again arguing about very much minor issues, without doing anything about, nor even touching, the more important ones. E.g., I asked up-thread whether you knew how many people review patches for Emacs; did you follow up on that? This is IMO much more important for Emacs development and eventually for its future than whether our CI will be from Gitlab or from somewhere else, definitely more important than the commit hooks issue.