From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 06 Apr 2019 19:00:58 +0300 Message-ID: <83a7h39l8l.fsf@gnu.org> References: <20190405103614.oivi4mtlnklldli4@Ergus> <835zrsd670.fsf@gnu.org> <20190405150404.bm2d6wjtivwyesek@Ergus> <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <834l7bbp9a.fsf@gnu.org> <83k1g79smt.fsf@gnu.org> <20190406152014.zykyiakddmwsmkko@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="146641"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 18:03:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCnn2-000c11-Kn for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 18:03:32 +0200 Original-Received: from localhost ([127.0.0.1]:56686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCnn1-0004fg-KU for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 12:03:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCnki-0003VQ-Qh for emacs-devel@gnu.org; Sat, 06 Apr 2019 12:01:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCnki-0008Fx-F8; Sat, 06 Apr 2019 12:01:08 -0400 Original-Received: from [176.228.60.248] (port=1067 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hCnkh-0000eP-J2; Sat, 06 Apr 2019 12:01:08 -0400 In-reply-to: <20190406152014.zykyiakddmwsmkko@Ergus> (message from Ergus on Sat, 6 Apr 2019 17:20:14 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235037 Archived-At: > Date: Sat, 6 Apr 2019 17:20:14 +0200 > From: Ergus > Cc: emacs-devel@gnu.org > > In the first one I extended the conditions for the character > selection. It is not perfect for the reasons we have exposed, but in the > mean time it will work for no very fancy conditions until we agree if we > should use | or find a better solution because I don't like that one :(, > it looks too ugly by default. I agree. > In the last commit I removed the Qfoo symbols which seems to fix the > customize-variable issue. > > I also removed the variables from frame.el because it seems they were > not needed when I followed the procedure. Assuming you bound the command to change the variables to a simple key, like F5, that's fine. "M-x set-variable", for example, won't do, because it activates the minibuffer, and that triggers a thorough redisplay. > I am wondering why in display-line-numbers the symbols are needed and > the inclusion in frame.el, but not for display-fill-column-indicator if > they are implemented in a so similar way. > > Whats the internal criteria for that? Some code to read? I just followed the procedure described there, AFAIR.