From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Sun, 02 May 2021 10:07:51 +0300 Message-ID: <83a6pd8vg8.fsf@gnu.org> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <24f3b5e7-3e5e-d00f-3fc4-9d093ca1dc10@daniel-mendler.de> <87fsz7wvu5.fsf@mail.linkov.net> <46a170c1-7d81-8ed5-e61a-d8193b640d16@daniel-mendler.de> <877dkirzvn.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15653"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, dgutov@yandex.ru, emacs-devel@gnu.org, monnier@iro.umontreal.ca, juri@linkov.net To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 02 09:09:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ld6Dz-0003xm-BO for ged-emacs-devel@m.gmane-mx.org; Sun, 02 May 2021 09:09:07 +0200 Original-Received: from localhost ([::1]:35506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld6Dy-0001bG-FJ for ged-emacs-devel@m.gmane-mx.org; Sun, 02 May 2021 03:09:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld6D6-0001AT-Um for emacs-devel@gnu.org; Sun, 02 May 2021 03:08:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57159) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld6D5-0002Qe-5H; Sun, 02 May 2021 03:08:11 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1811 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ld6D4-0000z4-Fi; Sun, 02 May 2021 03:08:10 -0400 In-Reply-To: (message from Daniel Mendler on Sun, 2 May 2021 02:43:20 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268755 Archived-At: > From: Daniel Mendler > Date: Sun, 2 May 2021 02:43:20 +0200 > Cc: Gregory Heytings , Dmitry Gutov , > Stefan Monnier , > "emacs-devel@gnu.org" > > > Maybe this choice could be handled by an option? > > Of course, we can add options to allow fine tuning of every behavior. > While I like the tuneability of Emacs I am not sure if it is advised to > make every tiny bit configurable. The way I wrote the current patch > allows the addition of custom `completions--insert-*` functions. > Furthermore there is always the advice mechanism, the possibility to > override functions etc, so I don't feel the need to add configurations > for every detail. We don't provide knobs for every behavior, indeed. But where the "right" behavior is a matter of personal preferences, and there are large enough groups of people who may want either of the possible behaviors, offering an option is TRT. Advice is not a valid replacement for a user option, because writing an advice is orders of magnitude harder than flipping an option, and requires the user to be proficient in ELisp.