From: Eli Zaretskii <eliz@gnu.org>
To: Sergey Organov <sorganov@gmail.com>
Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?
Date: Mon, 24 May 2021 17:27:35 +0300 [thread overview]
Message-ID: <83a6okdx60.fsf@gnu.org> (raw)
In-Reply-To: <871r9w5jws.fsf_-_@osv.gnss.ru> (message from Sergey Organov on Mon, 24 May 2021 16:41:07 +0300)
> From: Sergey Organov <sorganov@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,
> Stefan Monnier <monnier@iro.umontreal.ca>,
> Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Mon, 24 May 2021 16:41:07 +0300
>
> diff --git a/lisp/desktop.el b/lisp/desktop.el
> index fb7c6c79a1..20d9e0f268 100644
> --- a/lisp/desktop.el
> +++ b/lisp/desktop.el
> @@ -706,7 +706,8 @@ if different)."
> "\\)\\'")))
> (dolist (buffer (buffer-list))
> (let ((bufname (buffer-name buffer)))
> - (unless (or (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers
> + (unless (or (nill bufname)
> + (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers
> (string-match-p preserve-regexp bufname))
> (kill-buffer buffer)))))
> (delete-other-windows)
AFAICT, kill-buffer already is a no-op when the buffer is dead. So
what exactly does this fix? (Apologies if I'm missing something: I
cannot say that I've read all the discussions in this thread to the
last detail.)
next prev parent reply other threads:[~2021-05-24 14:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 23:14 Should (buffer-list) ever return killed buffers? Sergey Organov
2021-05-23 23:41 ` Stefan Monnier
2021-05-23 23:58 ` Sergey Organov
2021-05-24 3:32 ` Stefan Monnier
2021-05-24 14:15 ` martin rudalics
2021-05-24 14:23 ` Sergey Organov
2021-05-24 16:31 ` Stefan Monnier
2021-05-24 17:05 ` martin rudalics
2021-05-24 19:55 ` Stefan Monnier
2021-05-24 20:27 ` Sergey Organov
2021-05-25 6:49 ` martin rudalics
2021-05-24 13:41 ` [PATCH] " Sergey Organov
2021-05-24 14:04 ` Tassilo Horn
2021-05-24 14:25 ` Sergey Organov
2021-05-24 14:27 ` Eli Zaretskii [this message]
2021-05-24 14:50 ` martin rudalics
2021-05-24 15:05 ` Eli Zaretskii
2021-05-24 15:32 ` Sergey Organov
2021-05-24 16:07 ` [PATCH] " Philipp
2021-05-24 18:11 ` Sergey Organov
2021-05-24 18:31 ` Sergey Organov
2021-05-24 16:25 ` [PATCH] " Eli Zaretskii
2021-05-24 18:09 ` Sergey Organov
2021-05-24 16:04 ` martin rudalics
2021-05-24 16:30 ` Eli Zaretskii
2021-05-24 19:01 ` Stefan Monnier
2021-05-24 15:14 ` Sergey Organov
2021-07-22 11:27 ` Sergey Organov
2021-05-23 23:42 ` Clément Pit-Claudel
2021-05-23 23:55 ` Sergey Organov
2021-05-23 23:56 ` Clément Pit-Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a6okdx60.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).