From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Date: Mon, 16 Aug 2021 16:22:13 +0300 Message-ID: <83a6lh8qyi.fsf@gnu.org> References: <87o89ygyu8.fsf@gnus.org> <87bl5xfvjv.fsf@gnus.org> <83lf518ter.fsf@gnu.org> <87y291blfl.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22945"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tgbugs@gmail.com, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 15:23:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFcaW-0005hT-KP for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 15:23:36 +0200 Original-Received: from localhost ([::1]:44760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFcaV-0005YN-Df for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 09:23:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFcZI-0003vi-ES for emacs-devel@gnu.org; Mon, 16 Aug 2021 09:22:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47798) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFcZI-0002LG-7Y; Mon, 16 Aug 2021 09:22:20 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4056 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFcZH-0004oj-Qj; Mon, 16 Aug 2021 09:22:20 -0400 In-Reply-To: <87y291blfl.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 16 Aug 2021 14:53:18 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272438 Archived-At: > From: Lars Ingebrigtsen > Cc: tgbugs@gmail.com, emacs-devel@gnu.org > Date: Mon, 16 Aug 2021 14:53:18 +0200 > > Eli Zaretskii writes: > > > More importantly, what about selective-display, which replaces > > newlines with \r's? I think this replacement is for that use case. > > > > So perhaps the condition for the replacement should be > > selective-display? > > Aha! The initial revision of files.el had: > > +(defun hack-local-variables (&optional force) > [...] > + ;; Look at next local variable spec. > + (if selective-display (re-search-forward "[\n\C-m]") > + (forward-line 1)) > > So the ^M stuff that remains in here may have nothing to do with CRLF > DOS stuff, but is something that's left over from code meant to deal > with selective display? Yes, I think so. It just misfires in the obscure use case that triggered this discussion.