From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 b4f47d2: Use @pxref when necessary Date: Thu, 25 Nov 2021 11:03:38 +0200 Message-ID: <83a6hs7gk5.fsf@gnu.org> References: <831r358hrr.fsf@gnu.org> <87o868hcjd.fsf@gmail.com> <83bl287hfr.fsf@gnu.org> <87k0gwhba1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33692"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 25 10:04:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqAgA-0008SH-6M for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 10:04:30 +0100 Original-Received: from localhost ([::1]:56746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqAg8-0005au-Gb for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Nov 2021 04:04:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqAfK-0004u7-OT for emacs-devel@gnu.org; Thu, 25 Nov 2021 04:03:39 -0500 Original-Received: from [2001:470:142:3::e] (port=33688 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqAfJ-0000Cz-Qe; Thu, 25 Nov 2021 04:03:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rj9UIVhvNkPHsiyFcnunCOAKAxEqZJTM5jOiZyBIPy8=; b=UKk+m0RgJp8UTEiXB6rB PWJDijoQ5JbPbI6t6TabgXgc9lmkgq4yfbUqgotqC3HNCFDqX9Eguf2XrsuI9kniF3JeGZ4J9HMqy 13d1oYFvy9F9BihfHjd/FuQot5g6e68ffU4Plxl0HpmBj6s+ZsSvKSm52t5kgGY3WzRvmMLoIPinL oF74cw6GaAz8g80rEalDKXErsaIhTryoMx8SqFDOpWD4Bk/tgyl1l7oNRE3b7wLhfxqpidB0yqj3o LcXMbvi132NmiNL+UJmm5zMosLM3cd1uJYDqoffL9yKOYNz7+wNl3goT/9FofJ9t49EGv7OsWPt1u 8/ysT4lmwmYccg==; Original-Received: from [87.69.77.57] (port=1847 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqAfI-0006Te-RR; Thu, 25 Nov 2021 04:03:37 -0500 In-Reply-To: <87k0gwhba1.fsf@gmail.com> (message from Robert Pluim on Thu, 25 Nov 2021 09:47:34 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280085 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Thu, 25 Nov 2021 09:47:34 +0100 > > Eli> Fixes for the documentation are always safe, but that change was not a > Eli> fix, as there was no problem that needed to be fixed. > > The generated info manuals displayed "(see see" when viewed inside > Emacs, because thatʼs what "(see @ref" produces, unlike "(@pxref". This problem should be fixed in info.el, not in the Texinfo sources. (It should have been mentioned in the log message as well, btw.) There's nothing wrong with "see @ref" from the Texinfo usage POV. Moreover, some old enough versions of makeinfo don't produce correct output from @pxref that is not the first and the only one in parentheses, or is not in parentheses at all. I don't object to the change in the sources, either (which is why I did merge the change to master), but the change wasn't trivial and could have had unintended consequences where I didn't see any real problem to fix in the first place. Thanks.