unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-28 b4f47d2: Use @pxref when necessary
Date: Thu, 25 Nov 2021 11:03:38 +0200	[thread overview]
Message-ID: <83a6hs7gk5.fsf@gnu.org> (raw)
In-Reply-To: <87k0gwhba1.fsf@gmail.com> (message from Robert Pluim on Thu, 25 Nov 2021 09:47:34 +0100)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 25 Nov 2021 09:47:34 +0100
> 
>     Eli> Fixes for the documentation are always safe, but that change was not a
>     Eli> fix, as there was no problem that needed to be fixed.
> 
> The generated info manuals displayed "(see see" when viewed inside
> Emacs, because thatʼs what "(see @ref" produces, unlike "(@pxref".

This problem should be fixed in info.el, not in the Texinfo sources.
(It should have been mentioned in the log message as well, btw.)
There's nothing wrong with "see @ref" from the Texinfo usage POV.
Moreover, some old enough versions of makeinfo don't produce correct
output from @pxref that is not the first and the only one in
parentheses, or is not in parentheses at all.

I don't object to the change in the sources, either (which is why I
did merge the change to master), but the change wasn't trivial and
could have had unintended consequences where I didn't see any real
problem to fix in the first place.

Thanks.



  reply	other threads:[~2021-11-25  9:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 19:39 emacs-28 b4f47d2: Use @pxref when necessary Eli Zaretskii
2021-11-25  8:20 ` Robert Pluim
2021-11-25  8:44   ` Eli Zaretskii
2021-11-25  8:47     ` Robert Pluim
2021-11-25  9:03       ` Eli Zaretskii [this message]
2021-11-25  9:19         ` Robert Pluim
2021-11-25  9:52           ` Eli Zaretskii
2021-11-25 10:18           ` Robert Pluim
2021-11-25 10:53             ` Eli Zaretskii
2021-11-25 14:38               ` Robert Pluim
2021-11-25 16:54                 ` Eli Zaretskii
2021-11-25 17:15                   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a6hs7gk5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).