From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: sqlite3 Date: Fri, 17 Dec 2021 14:43:54 +0200 Message-ID: <83a6gze705.fsf@gnu.org> References: <87tufmjyai.fsf@gnus.org> <87mtl13vz2.fsf@gnus.org> <87ilvp3tzo.fsf@gnus.org> <83wnk5gduf.fsf@gnu.org> <87r1ab1y0r.fsf@gnus.org> <83sfurejs6.fsf@gnu.org> <871r2b1vu8.fsf@gnus.org> <83o85feitv.fsf@gnu.org> <87lf0jzifm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36099"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 17 13:49:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myCg2-00098F-Cf for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Dec 2021 13:49:34 +0100 Original-Received: from localhost ([::1]:44014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myCg0-0001IV-EW for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Dec 2021 07:49:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myCar-00076U-PO for emacs-devel@gnu.org; Fri, 17 Dec 2021 07:44:16 -0500 Original-Received: from [2001:470:142:3::e] (port=35168 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myCar-0004zt-GD; Fri, 17 Dec 2021 07:44:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=dtas2awuzQ6CYSM7S0cwiKqdkreAyyHPSTGylh1HJkg=; b=ErRfjTpPEKlqTI6b+eDg uGFFjiKHj4ZoqWDyvWS/WfbHsNuEkOmIEYpUKImyqru0X7gMuu0kO/b6760/6uGO3K5qXE21QfnTh DjqBhoLW8Hm3YfXvLe+ugOqYvNhzz406G/XRF8mk3W4oVkL+cxm3v4bGG4YKIpcRu41MiZvkYGFuQ rzOv9LAPoBWARl7tq7XpQZj0VziuX+KreINvv7tK2fEMIU3qx0W9Y8niYq/nNhjkFIc9N/G8I0Jmp upYKjfDOVC+BVkx9Po2JGUOE8yHkTCMBBibDGMzEKlULMrMnO1NPdQWk2sjZ88QfXEoPw1zbz2Kh3 8QhCSaaPmO/Ffw==; Original-Received: from [87.69.77.57] (port=1360 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myCan-0006JK-JX; Fri, 17 Dec 2021 07:44:13 -0500 In-Reply-To: <87lf0jzifm.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 17 Dec 2021 10:31:25 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282213 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Fri, 17 Dec 2021 10:31:25 +0100 > > Eli Zaretskii writes: > > > If you are sure the second session already exited, then my hand-waving > > doesn't hold water. > > I thought I was pretty sure, and... today I can't reproduce the problem > at all. 😐 It was 100% reproducible yesterday, but not today. (And I > reverted the change I made to handle the problem.) > > OK, I ran the tests a whole bunch of times now, and it failed once, so > the problem is still present, but hard to reproduce. I'll keep poking > at it, but I probably won't have time to continue today. Is that multi-test-files-simple? If so, it almost always fails here today: Test multi-test-files-simple condition: (ert-test-failed ((should (= (multisession-value sfoo) 2)) :form (= 1 2) :value nil)) Which sounds like a problem different from what you saw? Adding (sleep-for 3) after call-process doesn't entirely fix the problem, although it becomes more rare. I've installed a change in multisession.el that makes the problem much more rare by forcing 'fsync' when we close the value file. The problem is not yet gone entirely, though: it happens with about 25% probability here. I think it could be related to the fact that 'rename-file' is not an atomic operation on MS-Windows. But that's a wild guess, I have no basis for it.