* Renaming ts_* functions
@ 2022-10-16 19:09 Eli Zaretskii
2022-10-16 20:02 ` Christopher Dimech
2022-10-17 9:04 ` Yuan Fu
0 siblings, 2 replies; 6+ messages in thread
From: Eli Zaretskii @ 2022-10-16 19:09 UTC (permalink / raw)
To: Yuan Fu; +Cc: emacs-devel
I think I'd like to rename all the ts_* functions defined in treesit.c
to treesit_* names. This will allow us to distinguish easily between
our functions and functions from the tree-sitter library.
WDYT?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Renaming ts_* functions
2022-10-16 19:09 Renaming ts_* functions Eli Zaretskii
@ 2022-10-16 20:02 ` Christopher Dimech
2022-10-17 9:04 ` Yuan Fu
1 sibling, 0 replies; 6+ messages in thread
From: Christopher Dimech @ 2022-10-16 20:02 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Yuan Fu, emacs-devel
> Sent: Monday, October 17, 2022 at 7:09 AM
> From: "Eli Zaretskii" <eliz@gnu.org>
> To: "Yuan Fu" <casouri@gmail.com>
> Cc: emacs-devel@gnu.org
> Subject: Renaming ts_* functions
>
> I think I'd like to rename all the ts_* functions defined in treesit.c
> to treesit_* names. This will allow us to distinguish easily between
> our functions and functions from the tree-sitter library.
>
> WDYT?
It should really be done as suggested. Categorisation becomes even more
important as more tools get done.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Renaming ts_* functions
2022-10-16 19:09 Renaming ts_* functions Eli Zaretskii
2022-10-16 20:02 ` Christopher Dimech
@ 2022-10-17 9:04 ` Yuan Fu
2022-10-17 9:09 ` Eli Zaretskii
1 sibling, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2022-10-17 9:04 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> On Oct 16, 2022, at 12:09 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> I think I'd like to rename all the ts_* functions defined in treesit.c
> to treesit_* names. This will allow us to distinguish easily between
> our functions and functions from the tree-sitter library.
>
> WDYT?
Sure, I can do that. Or you can do it, if you have a smart workflow for mass-renaming functions ;-)
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Renaming ts_* functions
2022-10-17 9:04 ` Yuan Fu
@ 2022-10-17 9:09 ` Eli Zaretskii
2022-10-17 10:16 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2022-10-17 9:09 UTC (permalink / raw)
To: Yuan Fu; +Cc: emacs-devel
> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 17 Oct 2022 02:04:00 -0700
> Cc: emacs-devel@gnu.org
>
>
>
> > On Oct 16, 2022, at 12:09 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > I think I'd like to rename all the ts_* functions defined in treesit.c
> > to treesit_* names. This will allow us to distinguish easily between
> > our functions and functions from the tree-sitter library.
> >
> > WDYT?
>
> Sure, I can do that. Or you can do it, if you have a smart workflow for mass-renaming functions ;-)
I have some free time today, so I will do it, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Renaming ts_* functions
2022-10-17 9:09 ` Eli Zaretskii
@ 2022-10-17 10:16 ` Eli Zaretskii
2022-10-17 21:15 ` Yuan Fu
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2022-10-17 10:16 UTC (permalink / raw)
To: casouri; +Cc: emacs-devel
> Date: Mon, 17 Oct 2022 12:09:42 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> > From: Yuan Fu <casouri@gmail.com>
> > Date: Mon, 17 Oct 2022 02:04:00 -0700
> > Cc: emacs-devel@gnu.org
> >
> >
> >
> > > On Oct 16, 2022, at 12:09 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > >
> > > I think I'd like to rename all the ts_* functions defined in treesit.c
> > > to treesit_* names. This will allow us to distinguish easily between
> > > our functions and functions from the tree-sitter library.
> > >
> > > WDYT?
> >
> > Sure, I can do that. Or you can do it, if you have a smart workflow for mass-renaming functions ;-)
>
> I have some free time today, so I will do it, thanks.
Now done.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Renaming ts_* functions
2022-10-17 10:16 ` Eli Zaretskii
@ 2022-10-17 21:15 ` Yuan Fu
0 siblings, 0 replies; 6+ messages in thread
From: Yuan Fu @ 2022-10-17 21:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> On Oct 17, 2022, at 3:16 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Date: Mon, 17 Oct 2022 12:09:42 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>>
>>> From: Yuan Fu <casouri@gmail.com>
>>> Date: Mon, 17 Oct 2022 02:04:00 -0700
>>> Cc: emacs-devel@gnu.org
>>>
>>>
>>>
>>>> On Oct 16, 2022, at 12:09 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>>
>>>> I think I'd like to rename all the ts_* functions defined in treesit.c
>>>> to treesit_* names. This will allow us to distinguish easily between
>>>> our functions and functions from the tree-sitter library.
>>>>
>>>> WDYT?
>>>
>>> Sure, I can do that. Or you can do it, if you have a smart workflow for mass-renaming functions ;-)
>>
>> I have some free time today, so I will do it, thanks.
>
> Now done.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-17 21:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-16 19:09 Renaming ts_* functions Eli Zaretskii
2022-10-16 20:02 ` Christopher Dimech
2022-10-17 9:04 ` Yuan Fu
2022-10-17 9:09 ` Eli Zaretskii
2022-10-17 10:16 ` Eli Zaretskii
2022-10-17 21:15 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).